bootstrap.sh should check out submodules by default

[buildkite]

bootstrap.sh should check out submodules by default

[toolmantim]

@blueimp can you give the bootstrap from #168 a go? I've added a BUILDKITE_DISABLE_GIT_SUBMODULES environment variable for disabling the git submodule checkout commands.

[keithpitt]

Yeah sounds sensible! I'll look at adding it to the default bootstrap.sh, thanks!

[sj26]

The clone and fetches should probably --recurse-submodules, then the checkout should just work(tm).

[keithpitt]

The only thing I'm unsure about is checking out commits with submodules. If I start a repo git clone --recurse-submodules then a git fetch --recurse-submodules, and then git checkout x, will the git checkout change the git submodules to the right commit? I've never used them before.

[tarragon]

Nope, you still need to do a git submodule update or to be safer you can git submodule update --init.

[sj26]

Yep, but if you recurse submodules on the clone and fetch there shouldn't be any network involvement :-)

[ahawkins]

Please do the git submodule update --init approach. I found this out the hard way today. If you use --recurse on git clone, that only works on the first build (since the repo hasn't been cloned yet). Branches that introduce submodules will still need git submodule update --init.

[keithpitt]

@ahawkins are you doing a git submodule update --init in your bootstrap.sh file?

[keithpitt]

I've added it to our bootstrap.sh for the upcoming 1.0 release of the agents: https://github.com/buildkite/agent/blob/master/templates/bootstrap.sh#L107

[keithpitt]

If you'd like similar behaviour now, just copy those 3 lines into your current bootstrap.sh

Thanks everyone for your help!! 👯

[blueimp]

Sorry to comment on a closed issue, but would it be possible to disable the git submodule calls with a buildkite configuration setting or an environment variable?

This would be useful for minimal agents without perl installed (git submodules require perl).

Tasks on an agent without perl don't break, but they still display error messages like this:

/usr/libexec/git-core/git-submodule: line 1: /usr/bin/perl: not found

Currently I'm disabling git submodule calls with the following command, but that's rather brittle:

sed -i 's/\(git submodule\)/true \1/g' /buildkite/bootstrap.sh

[blueimp]

Thanks, I've added my comment to #168