Comments (5)
Hi @cobrobrown ,
Absolutely, you are welcome to contribute. You can start doing a Fork
in GitHub of this repository, then you can work in your own repository. When you finish, you can do a Pull Request
. Then, I will check your pull request and probably I will merge.
Let me know if you need anything more!
Best,
Darío.
from ta.
Added on new 0.4.1 version
from ta.
I'm requesting this issue be re-opened.
Further to this, I think this should be optional for every indicator and not mandatory.
For example, in normal use on most technical analysis/charting app, a 20 bar indicator doesn't start until bar number 20. With the min_periods=0, values are populated for the first 19 bars.
Source: I've used plenty of TA apps over the past 20 years. MetaStock, AmiBroker, various charting libraries, TradeStation, Multicharts, NinjaTrader, RightEdge, Advanced GET, Fcharts, Market Analyst, Omnitrader to name a few... None of them plot anything in the first 19 bars on a 20 bar indicator.
from ta.
Hi @RichardDale and @cobrobrown ,
I am agree with @RichardDale , I think we should delete the min_periods=0
and fill_value=x
.
Let me know if you are agree.
Best,
Dario
from ta.
What @RichardDale describes is what can be described as a basic guarantee, i.e.:
- The length of the input buffer is equal to the length of the output buffer
- As long as the minimum period of the indicator has not been met, the value to be produced has to be a non-value
The standard fill value for non-defined output values is NaN
, for a very simple reason:
- It is NOT a value and defined so in a standard and it can be tested for such (which allows for easy filtering, hence the
...na
machinery inpandas
and other frameworks - It is skipped by plotting frameworks like
matplotilb
from ta.
Related Issues (20)
- Default window
- MACD errors HOT 1
- volume_price_trend is completly wrong HOT 2
- requesting two indicators HOT 1
- Confusion about Force Index HOT 1
- Add parameter "exclude_ta_features" from add_all_ta_features.
- Why does Bollinger Bands use ddof=0 instead of the default ddof=1? HOT 1
- FutureWarning (with pandas 1.5.1) HOT 1
- ADXIndicator.adx_pos / adx_neg head assertion failed
- AroonIndicator from trend.py based on inadequate input HOT 2
- Bollinger Band data series - something is off HOT 1
- Feature Request: Support incremental computation
- calculate daily return will use future infomation HOT 3
- ADX indicator on stockcharts is wrong (and therefore, it's implementation here too, I guess) HOT 1
- RSIIndicator: Value Error HOT 1
- add_all_ta_features not installing due to bug on OnBalanceVolumeIndicator
- Issue with ADXIndicator interacting with numpy HOT 1
- FutureWarning HOT 1
- not compatible with python 3.12? HOT 1
- Can't install ta with Anaconda on windows
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ta.