Comments (1)
I've tested and made a conclusion. To both questions, the answer is no.
- We don't need to add a version of stimulus in
package.json
- We shouldn't require the root inclusion of stimulus in
app/javascript/controllers/index.js
to be standardized on@hotwired/stimulus
3.0.
Rationale:
- If the main stimulus is 3.0, including 2.0 packages will throw an error in the browser.
- If we don't specify a version of stimulus in package.json but sub-packages reference a variety of version (ie. a mix of 2.0 and 3.0 packages),
yarn
will be smart enough to target the oldest version of the package, betting that it'll be forward compatible. The currentyarn.lock
references@hotwired/stimulus@^3.0.1
but if we include a package using stimulus 2.0 (e.g.@hammerstone/refine-stimulus
), thenyarn.lock
will includestimulus@>=2.0 <3
.
from bullet_train.
Related Issues (20)
- dates_helper_test makes assumptions about root_path HOT 1
- Resolver system test fails with ejected template
- Github action improvements
- Should `strong_passwords` default to `false` in development? HOT 1
- Flaky test HOT 8
- Problems with passing a local path to `bin/hack` HOT 3
- Do we have a test isolation problem?
- Can we get simplecov to report coverage of BT gems as well?
- Remove un-needed code to clean up `.github/workflows/main.yml`
- Do we still need `lib/bullet_train_oauth_scaffolder_support.rb`? HOT 1
- Add a `Brewfile` HOT 1
- Do we really need Overmind? HOT 2
- Can we help if postgres isn't running
- Can we help if redis isn't running?
- Problem with UserMailer#invite & postcss-css-variables?
- Can we provide a GitHub action that automatically generates a PR to upgrade an app? HOT 2
- Run `rails g model` in `bin/super-scaffold` step HOT 2
- Resolver test fails if you've ejected the partial
- Invitation tests use wrong route HOT 1
- Bundle install not working fine in main branch HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bullet_train.