Giter Site home page Giter Site logo

Comments (17)

egil avatar egil commented on August 26, 2024 1

Upgrading to <PackageReference Include="bunit" Version="1.24.8-preview" /> fixes the problem for me.

from bunit.

egil avatar egil commented on August 26, 2024 1

Ah fair - I also run rc.2 locally. But that bit is anyway interesting. Why should it fail with a type that is provided by the framework and not us.

Guessing it is because rc1 and rc2 are not binary compatible.

from bunit.

msynk avatar msynk commented on August 26, 2024 1

@linkdotnet Thanks a lot. the latest preview version (1.24.9-preview) is working fine for me 👏.

from bunit.

msynk avatar msynk commented on August 26, 2024

I think the issue is coming from this line:

var cascadingParamAttr = propertyInfo?.GetCustomAttribute<CascadingParameterAttribute>(inherit: true);

and the fact that the CascadingParameterAttribute now has a base class named CascadingParameterAttributeBase in .NET 8 RC 2

from bunit.

egil avatar egil commented on August 26, 2024

Hmm interesting. Wonder why our own tests haven't caught this. Can you provide an example of a test that causes this. Should be a pretty easy fix though, so we should be able to get a fix out soon.

from bunit.

linkdotnet avatar linkdotnet commented on August 26, 2024

Even with the new introduction of the new base class, that shouldn't much interfere with the usage.

As @egil mentioned, it would be really helpful to have a minimal reproducible example for us.
We have many tests in combination with cascading parameters and not of them experienced such an exception.

from bunit.

msynk avatar msynk commented on August 26, 2024

here is the sample repo: https://github.com/msynk/bUnitNet8RC2

It seems this exception throws only for the components with parameters.

from bunit.

linkdotnet avatar linkdotnet commented on August 26, 2024

Interesting - the same test passes when moved inside our test suite.

from bunit.

msynk avatar msynk commented on August 26, 2024

@linkdotnet really interesting.
I've run the tests in both stable and preview versions of bUnit (1.23.9, 1.24.3-preview) with the same results.

from bunit.

linkdotnet avatar linkdotnet commented on August 26, 2024

Sorry - I meant I moved the test inside the bUnit code and let it run there. No issue at all. Even if I check out 1.23.9 and let the test run.

from bunit.

egil avatar egil commented on August 26, 2024

Is it a mstest thing?

from bunit.

linkdotnet avatar linkdotnet commented on August 26, 2024

Thought so too and "migrated" the given example to xUnit with the same outcome - still failing tests with the given exception.

from bunit.

linkdotnet avatar linkdotnet commented on August 26, 2024

With 1.22 (where we don't explicitly support net8.0) it works like a charm (which makes sense given the context).

from bunit.

egil avatar egil commented on August 26, 2024

Doing a new preview release now that will build against RC2. Perhaps that fixes the issue. Guessing the package on nuget.org is build against rc1 and that is causing the failure. We cannot replicate when adding the tests and running against bunit sources.

from bunit.

linkdotnet avatar linkdotnet commented on August 26, 2024

Ah fair - I also run rc.2 locally.
But that bit is anyway interesting. Why should it fail with a type that is provided by the framework and not us.

from bunit.

linkdotnet avatar linkdotnet commented on August 26, 2024

Okay - @msynk can you confirm that it also works on your side?

from bunit.

linkdotnet avatar linkdotnet commented on August 26, 2024

Nice!

from bunit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.