Comments (8)
That's a great question. I don't know what the right answer is. On the one hand, there is value (IMO) in keeping the dependencies limited to only the standard library. On the other hand, collect
seems to be gaining traction and has other data structures that might be worth writing Arbitrary
impls for.
I think we can have our cake and eat it too. What if I created a new crate inside this repository that contained impls for Arbitrary
from third party libraries? (Starting with collect-rs
.)
from quickcheck.
@zsiciarz P.S. Love your 24 days of Rust blog ports. :D
from quickcheck.
What if I created a new crate inside this repository that contained impls for Arbitrary from third party libraries?
Sadly, you can't do that. You need to implement Arbitrary
for external structs in the quickcheck
crate because that's where Arbitrary
is defined. Otherwise you'll end with:
extern crate collect;
extern crate quickcheck;
use quickcheck::Arbitrary;
use collect::TrieMap;
impl<A: Arbitrary> Arbitrary for TrieMap<A> {}
//~^ error: cannot provide an extension implementation where both trait and type are not defined in this crate
from quickcheck.
... duh. I must have been out of sorts this morning.
OK. I'm not a big fan of it, but I think I'll just keep the impl and the dependency inside QuickCheck proper for now. If we run into problems or if it becomes a maintenance burden, we can re-evaluate.
(If there's anything I've missed or if someone else wants to weigh in, please do!)
from quickcheck.
@BurntSushi Cargo has this "features" ... feature (which I haven't tried yet) that let's you specify optional dependencies. Do you think it would be a good idea to add a "collect" feature that makes both the dependency on collect-rs
and the impl Arbitratry for TrieMap
optional? That way the default quickcheck
build would be dependency-free.
from quickcheck.
@japaric That sounds like another good idea. How about we retain the status quo until there is a problem? I don't mind collecting impls, but if the deps break a lot, it could be a maintenance burden.
An argument in favor of these impls is that they aren't exactly trivial to write. :-/
from quickcheck.
@BurntSushi Personally, I'd like to make the default build of quickcheck
dependency-free because that'd follow Rust's "pay for what you use" philosophy. If you need TrieMap
s then you can opt-in via the collect
feature and you pay with one more cargo dependency (that may break daily nightly :-)).
If interested I can send a PR, it's just an 8 line commit.
from quickcheck.
Yeah, that does sound good, particularly in the midst of a broken dependency. I can't test any of my code!
Send the PR on over. Thanks. :D
from quickcheck.
Related Issues (20)
- Cannot use Rng methods on `Gen` when implementing `Arbitrary` HOT 5
- Identity checking HOT 3
- Stack overflow in quickcheck case shrinking HOT 3
- example case sort TEST FAILED HOT 1
- QuickChecking Const Generic Code HOT 5
- Implement Arbitrary for AsMut<[T: Arbitrary]> HOT 2
- Infinite Repetition/Never Ending Test with `f32` and `f64`. HOT 17
- Q: Idiomatic way to specify the length of an arbitrary vector HOT 7
- <newbie> How to generate a number within a range HOT 2
- Negating an integer leads to stack overflow HOT 2
- upgrade notes would be nice. HOT 1
- debug_reprs taking up 41% of test runtime HOT 2
- warning: panic message is not a string literal HOT 1
- Rng Size for Vec Arbitrary cannot be 0
- Impl Clone for Gen
- Implement something like choose_weighted for `Gen`
- Is this still maintained? HOT 1
- Is quickcheck still maintained? HOT 1
- How to combine quickcheck 1+ with fake? HOT 3
- Durations's Arbitrary instance is dependant on Gen's size HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quickcheck.