Giter Site home page Giter Site logo

Comments (2)

DALDEI avatar DALDEI commented on June 19, 2024

src/main/java/io/burt/athena/result/csv/VeryBasicCsvParser.java
If columnCount ends up 0 then next() never advances.

from athena-jdbc.

iconara avatar iconara commented on June 19, 2024

Thank you, good catch. Would you like to take a stab at fixing it? You've already identified the source of the CSV parsing issue. I think you can duplicate this test

@Nested
class WhenTheInputIsEmpty {
@BeforeEach
void setUp() {
parser = new VeryBasicCsvParser(createInput(new String[0][0]), 3);
}
@Test
void returnsNull() {
assertNull(parser.next());
}
}
and change the 3 (the number of columns) to a 0 to trigger the bug (also duplicate the corresponding test for hasNext).

from athena-jdbc.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.