Giter Site home page Giter Site logo

Comments (10)

burzum avatar burzum commented on May 19, 2024

ok!

from cakephp-file-storage.

burzum avatar burzum commented on May 19, 2024

Let me know if I'm missing something, first time I set this up for a cakephp plugin 7f33e2a

from cakephp-file-storage.

mcallisto avatar mcallisto commented on May 19, 2024

@burzum thank you very much, really nice of you.

I loaded it with the following app/composer.json in my project and the update was completed

{
    "config": {
        "vendor-dir": "Vendor"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/burzum/FileStorage.git"
        }    
    ],
    "require": {
        "burzum/FileStorage": "dev-develop"
    }
}

Note that doing so the Gaufrette library is in app/Vendor/knplabs/gaufrette this means adding in app/Config/bootstrap.php the following lines

Configure::write(
    'FileStorage.GaufretteLib',
    APP . 'Vendor' . DS . 'knplabs' . DS . 'gaufrette' . DS . 'src' . DS
);

from cakephp-file-storage.

mcallisto avatar mcallisto commented on May 19, 2024

First problem: with the app/composer.json posted in my previous (above) comment, the plugin is created in Plugin/Filestorage (with lower case s) instead of Plugin/FileStorage (with upper case s).

As a comparison I am using also https://github.com/cakephp/debug_kit and this is correctly created in Plugin/DebugKit.

So I wonder if:

  • there is a solution (not found it yet) in the json syntax for this, allowing to change the name of the root folder of the plugin
  • or the name of the Git repository must be changed

from cakephp-file-storage.

burzum avatar burzum commented on May 19, 2024

This is an issue of the composer CakePHP installer -> https://github.com/composer/installers/blob/master/src/Composer/Installers/CakePHPInstaller.php

It does not handle CamelCasedWords correctly.

I've fixed it https://github.com/burzum/installers/commit/87e0ea2e85b47a90c4cba1556a8b76f199e120d8 and created a pull request composer/installers#89

As a workaround please try this:

"extra": {
    "installer-paths": {
        "Plugin/FileStorage": ["vendor/package"]
    }
}

See http://getcomposer.org/doc/faqs/how-do-i-install-a-package-to-a-custom-path-for-my-framework.md

from cakephp-file-storage.

mcallisto avatar mcallisto commented on May 19, 2024

Thank you, running composer update, due to your accepted pull request, now installs the plugin with the correct name.

If you agree, these could be the possible next steps:

  1. Adding an app/composer.json to https://github.com/cakedc/imagine
  2. Having this dependency suggested (not required) in this app/composer.json

from cakephp-file-storage.

mcallisto avatar mcallisto commented on May 19, 2024

As a first step, I proposed this pull request https://github.com/mcallisto/Imagine/commit/5d9f732c3fadad049a113a0a8ffab7bac5476d01

from cakephp-file-storage.

burzum avatar burzum commented on May 19, 2024

Merged it.

from cakephp-file-storage.

mcallisto avatar mcallisto commented on May 19, 2024

Sorry, it contained a typo, my mistake, see https://github.com/mcallisto/Imagine/commit/f78c08988bd1bfa2dfdda86d5a0e86e54b8d208c

from cakephp-file-storage.

burzum avatar burzum commented on May 19, 2024

Thanks for the PR!

from cakephp-file-storage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.