Xcode 8.3 beta compilation fails

[button]

Xcode 8.3 beta compilation fails

[Unihilator]

can't wait to merge it guys

[igor-makarov]

My PR #121 fixes that.

[taher-mosbah]

@seanjsummers deleting the content of the file "fixed" the problem for me.

[igor-makarov]

Yeah, I've got my Podfile pointed at my fork for a couple of days @platedbay

[chrismaddern]

@wessmith will be shipping a new version today @igor-makarov 😄

[wessmith]

Closed in #121 and part of 1.2.2

[superpeteblaze]

Likewise, seeing this compilation failure with Xcode 8.3 beta.

[ranganathagv]

If you just want to run you can comment that file content and run, but not sure how functionally it breaks

[salabaha]

https://developer.apple.com/library/content/releasenotes/DeveloperTools/RN-Xcode/Chapters/Introduction.html

Known Issues
When building a framework that has module maps in both the source and the install directories that define the same module, the compiler will show a redefinition message. (28638816)
Workaround: Rename the module map file in the source directory to a non-default name (the default name is module.modulemap or module.map), and set the Module Map File build setting to the renamed module map.

[igor-makarov]

I suggest specifying the public and private headers in the podspec and getting rid of the manually defined module map altogether.

Link to relevant chapter in the Podspec docs

[Ekhoo]

Any chance to release a fix ?

[Ekhoo]

👍

[igor-makarov]

My PR got merged. @chrismaddern can you please tag out a new release for @taher-mosbah @superpeteblaze @Ekhoo who are waiting for it in this thread.

[platedbay]

Definitely excited for this to roll out too, just a friendly reminder that you can point your source to a specific commit/branch if you don't want to wait around for a new release and subsequent pod update (if using cocoapods). We've been doing this to keep development rolling.

[igor-makarov]

BTW all tests are passing but Slather can't find the coverage output, so Coveralls isn't updated. I don't know enough about those tools to fix it 😂 @chrismaddern @wessmith

[Unihilator]

New arrives after a fix. But probably it's only mine.

../DebugTest-iphonesimulator/DeepLinkKit/DeepLinkKit.framework/Modules/module.modulemap:2:19: Umbrella header 'DeepLinkKit-umbrella.h' not found

[igor-makarov]

@Unihilator Well, since now the module map is auto generated, it's a CP issue...

[Unihilator]

Probably.. removed workspace and pod dir. updated pods - and now it's ok