Giter Site home page Giter Site logo

Comments (4)

bvaughn avatar bvaughn commented on May 19, 2024 1

I'm not thrilled with either approach, but I think I like the first approach better than the wrapper object.

from react-highlight-words.

bvaughn avatar bvaughn commented on May 19, 2024

No, there's no way currently to do that.

I'm a little reluctant to spread remaining props that way, but...maybe that would be the least awkward approach for this use case.

If you'd be willing to put together a PR (including tests and documentation updates) I'll review it.

from react-highlight-words.

ioloie avatar ioloie commented on May 19, 2024

Would it be better to spread remaining props as above or to add a dedicated prop object:

const spanProps={
  title: 'Play Game',
  'data-ext': 'test'
}

return (<Highlighter
  className="gameName"
  highlightClassName="highlightName"
  searchWords={searchValue}
  textToHighlight={content.gameName}
  spanProps={spanProps}
/>)

from react-highlight-words.

bvaughn avatar bvaughn commented on May 19, 2024

Published as 0.16.0

Thanks for contributing!

from react-highlight-words.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.