Comments (4)
That's a good point. It's because I haven't needed to use the WiFi for anything except for NTP time so far. Do you have some suggestions? Maybe another constructor that does not require the setup()
method to be called? I'm happy to look at well-crafted pull requests.
from acetime.
Thanks. I am thinking about constructor with no parameters; other operations should check that Wi-Fi is connected before interacting with the network. With setup() or not, it's worth doing this anyway, because Wi-Fi connection can go away any time. Perhaps, a constructor could take an optional WiFiUDP object, for projects which have already allocated it for their own use.
I'll try to submit something along these lines, but no hard promise :-)
from acetime.
I made some tweaks and fixes, and pushed them to the develop branch. Things look good.
I'll leave this issue open for now, until I get back from vacation. (Will be unable to respond for a couple of weeks.)
from acetime.
Thanks.
from acetime.
Related Issues (20)
- createForZoneName no longer working for "Europe/Amsterdam" HOT 4
- gcc 11.3 compiler warning HOT 4
- Getting this error compiling for ESP32 HOT 1
- 2.3.0 compile issues HOT 4
- Prevent incorrect initialization HOT 1
- Constructor for NtpClock::setup() missing HOT 2
- Day of week calculation is off by one HOT 2
- Need to support other WiFi platforms like the Nano 33 IOT, Maker Wifi ,etc HOT 33
- In OLED clock manual mode, can't set the clock HOT 3
- Q: AceTime with external database? HOT 5
- support megaAVR boards (e.g. Nano Every) HOT 1
- support arduino:samd Core >= 1.8.10 HOT 1
- Question: Does Acetime support standalone determination of timezone using GPS module? HOT 16
- List timezone names HOT 6
- ESP32 support HOT 2
- Broken SAMD core testing because of AceTime HOT 2
- Include order issue HOT 3
- How to handle error in lookup HOT 1
- Looking up by shortname? or TZ name? or CountryCode?
- Is AceTime working with ESP32 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from acetime.