Giter Site home page Giter Site logo

Comments (4)

saudet avatar saudet commented on May 18, 2024

Hi, could you include a link to that Codec.getInstalledCodecs() method? Thanks!

from javacv.

ironhawk avatar ironhawk commented on May 18, 2024

What do you mean? I dont have any links. I just modified it locally...

Besides the above
I found other issues

in Configurable.java
/**
* Set new profile.
*
* @param profile new profile.
*/
public void setProfile(int profile) {
this.profile = bitrate;
}
why are we assigning bitrate?

in Encoder.java
this method

public void setSampleRate(int samplerate) throws JavaAVException {
    if (codec.getType() != MediaType.AUDIO)
        throw new JavaAVException("Cannot set sample rate for non-audio codec.");

    List<Integer> supportedRates = Arrays.asList(codec.getSupportedSampleRates());

    if (!supportedRates.contains(samplerate)) {
        // pick the highest supported sample rate
        samplerate = supportedRates.get(supportedRates.size() - 1);

        if (LOGGER.isWarnEnabled()) {
            LOGGER.warn("Sample rate {} is not supported by {}.", samplerate, getCodec().getName());
            LOGGER.warn("-> Selected supported sample rate {}.", samplerate);
        }
    }

I got index out of range exceptions because of this a couple of codecs returned empty supportedRates which is not checked
line
samplerate = supportedRates.get(supportedRates.size() - 1);
will fail

from javacv.

saudet avatar saudet commented on May 18, 2024

Where can I find the Configurable.java and Encoder.java files?

from javacv.

saudet avatar saudet commented on May 18, 2024

I'm guessing this is about JavaAV, so you should probably ask about that over there:
https://github.com/hoary/JavaAV/issues

from javacv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.