Giter Site home page Giter Site logo

Comments (9)

Bytezz avatar Bytezz commented on July 23, 2024 1

Thanks @bertob for reporting.
Lately I've been a bit of touch so I've missed these new guidelines.
Will comply as soon as I have time.

Anyway, I would like to point out that, since there are a LOT of different default configurations on a LOT of different distros, maybe windows' title buttons position should not concern that much. But I understand the motivation.

from iplookup-gtk.

Bytezz avatar Bytezz commented on July 23, 2024 1

Don't worry, I've noticed it as soon as I pushed the commit.
Force pushed amended commit right after.

from iplookup-gtk.

bertob avatar bertob commented on July 23, 2024

Anyway, I would like to point out that, since there are a LOT of different default configurations on a LOT of different distros

That's why we specify that it's the platform default, rather than the distro. There are thousands of distros, but only a handful of app platforms (GNOME, KDE, elementary), and unlike with distros there is a single clear default there :)

from iplookup-gtk.

Bytezz avatar Bytezz commented on July 23, 2024

That's why we specify that it's the platform default, rather than the distro.

Ok, that makes sense.

Going back to screenshots, are half dark/light theme screenshots ok?
iplookup-1

from iplookup-gtk.

bertob avatar bertob commented on July 23, 2024

No, screenshots should be not be edited. You can include one or two extra screenshots in dark to show that it's supported, but otherwise just use the default (light).

By the way, your example here is a bit too small, I'd try to go as close to 1000x700 as possible (maybe a bit narrower in this case since it's just a single list, e.g. 700x700 or so?).

from iplookup-gtk.

Bytezz avatar Bytezz commented on July 23, 2024

Sorry for late response (I'm on vacation).
What about these?
Screenshot from 2024-02-10 17-53-22
Screenshot from 2024-02-10 17-53-31

These are very close to 700x700px (698x605px with shadows)

from iplookup-gtk.

bertob avatar bertob commented on July 23, 2024

Would be even better without visible scrollbars, but looks great otherwise!

from iplookup-gtk.

Bytezz avatar Bytezz commented on July 23, 2024

Closed by a78591a8b762b7eb00de956f792ab197061fa74c

from iplookup-gtk.

bertob avatar bertob commented on July 23, 2024

Just realized that the window controls are non-default (close button should be on the right), sorry for not catching this earlier 😞

from iplookup-gtk.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.