Giter Site home page Giter Site logo

Comments (3)

grayswandyr avatar grayswandyr commented on May 24, 2024

Got it!
I should have written:

utop # let s4 = S.group_by ~hash:(fun (a, _) -> String.hash a) 
~eq:(fun (a1, _) (b1, _) -> String.equal a1 b1) s;;
val s4 : (string * string) list S.t = <fun>
utop # print2 s4;;
[("a", "f"), ("a", "e"), ("a", "d")]
[("b", "f"), ("b", "e"), ("b", "d")]
[("c", "f"), ("c", "e"),
("c", "d")]
- : unit = ()

So it was not clear for me, from the documentation, what the hash function had to do... Perhaps the doc should be updated here, but I don't really know how to formulate this...

from iter.

c-cube avatar c-cube commented on May 24, 2024

Ok, I see. The invariant you were missing is quite classic: eq x y ==> hash x = hash y. In this particular case it would not hold.

from iter.

c-cube avatar c-cube commented on May 24, 2024

I added the invariant to the docs,thanks. Release incoming.

from iter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.