Unexpected results with from_hex method and demo page

[c0bra]

Unexpected results with from_hex method and demo page

[c0bra]

@bsebastian86 thanks for that tip, and sorry for the delay.

I finally found a way to convert rgb to ryb so it looks like the demo page from from_hex method is working properly now.

[bsebastian86]

Hi, seems this is a two year old issue that was unaddressed.

I noticed that this was giving the wrong results also, even on the demo page. Can you please tell me how to fix this? Thanks.

[c0bra]

@bsebastian86 it looks like there's something being calculated incorrectly in rgb2hsv, however when I plug in different implementations, like this one: https://gist.github.com/mjackson/5311256, I still get an incorrect hue of 0 for the first color.

I checked Color::Scheme itself and it correctly returns 180 for the first color's hue. Its code for rgb2hsv hasn't changed in 11 years: https://github.com/rjbs/Color-Scheme/blob/master/lib/Color/Scheme.pm#L260

At this point I'm not sure where the issue lies... 😕

[bsebastian86]

@c0bra i think it's because you are using the "h" value from HSV directly. The Hue here is based on the RGB color wheel, and not the RYB color wheel which the from_hue is based on.

This is actually my problem here. I need the formula to convert the Hue degree based on the RYB instead of the RGB. Can't find any resources on it, but Adobe's color and Paletton seem to have come up with it already... Programming is tough.