Giter Site home page Giter Site logo

Does not build out-of-tree about cachelot HOT 7 CLOSED

cachelot avatar cachelot commented on June 10, 2024
Does not build out-of-tree

from cachelot.

Comments (7)

Bu11etmagnet avatar Bu11etmagnet commented on June 10, 2024 1

Thanks for implementing this.

from cachelot.

aka-rider avatar aka-rider commented on June 10, 2024

Thank you for the bug report. I haven't tried to build cachelot using ninja yet.
Will try to address this issue ASAP.

from cachelot.

aka-rider avatar aka-rider commented on June 10, 2024

Can you please try to build cachelot from the root project directory (without switching to the __build)? It should work then.

Build out of root directory isn't supported really.

Please let me know if it would work for you or not.

from cachelot.

Bu11etmagnet avatar Bu11etmagnet commented on June 10, 2024

Building in the root works (only tried ninja).

-Isrc (which in case of out-of-tree build becomes -I../src) seems to be insufficient for out-of-tree builds.

I managed to build one of the sources by manually running the compilation command and adding -Isrc -Isrc/cachelot before the -I../src generated by CMake.

Perhaps common.h should #include "cachelot/config.h" instead of just "config.h", and then only -I../src would be needed.

from cachelot.

aka-rider avatar aka-rider commented on June 10, 2024

Building in the root works (only tried ninja).

Great news!

Perhaps common.h should #include "cachelot/config.h" instead of just "config.h"

Thank you for the suggestion. There was no reason to keep one include differently.

Changed in: 7c65900

I'm closing this issue.

from cachelot.

Bu11etmagnet avatar Bu11etmagnet commented on June 10, 2024

Unfortunately, this change is not enough. -Isrc is needed (to find config.h under the build dir) in addition to the -I../src currently generated by CMake.

from cachelot.

aka-rider avatar aka-rider commented on June 10, 2024

-Isrc is needed (to find config.h under the build dir) in addition to the -I../src currently generated by CMake.

I was not going to support out-of-tree builds, but here it is.
The reason of the compilation error was that config.h and version.h were created in the wrong place.
The fix is in the master.

from cachelot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.