MSBuild properties are incorrectly formatted

[Lordfirespeed]

MSBuild properties are incorrectly formatted

[Lordfirespeed]

Leaving this here for any future unfortunate souls -
When working with DefineConstants, semicolons within its property value need to be escaped with %3B.

The solution I proposed above will not work, each subsequence DefineConstants overwrites the value of the previous. The rendered constants ["foo", "bar", "baz'] should loook like:

/p:DefineConstants=foo%3Bbar%3Bbaz

[Lordfirespeed]

This does beg the question: Why are semicolons explicitly not escaped for DefineConstants?

private static readonly HashSet<string> _propertiesNotEscapeSemicolons = new HashSet<string>
{
    "DefineConstants",
    "ExcludeFilesFromDeployment"
};