Comments (10)
Might also be related to
#2242
Which is now in v0.15 version release.
You can backport this to v0.14 one if needed.
v0.13 might be EOL now.
from phinx.
To address cakephp/migrations#651 and this issue, we'd need to backport #2242 to v0.13. There is also the changes to getQueryBuilder
from 37307f8 that might be useful (though make it optional to pass argument and if no argument, default to current behavior of using newQuery
vs throwing exception).
Granted, given that newQuery
in favor of using the specific methods was deprecated in cakephp and the type problems with getQueryBuilder
that motivated #2242, I wonder if we shouldn't also deprecate getQueryBuilder
to be removed in 0.16 as well. Thoughts on that @dereuromark?
from phinx.
Biggest reason would be to help cakephp/migrations@v3 users, but if you don't think you'd want those methods in phinx proper for that (or fine with just having those users be stuck with the deprecation warnings), then yeah, less of a reason to backport that far unless @malle-pietje provides a compelling reason on why they might be stuck on 0.13.
from phinx.
I checked and the reason we had to pin to version 0.13 has been fixed so we should be able to move to 0.14. That means a backport would be welcome for us and any other projects that need to support PHP 7.4.
I know, PHP 7.4 is EOL but you don't want to know how many servers are still running it... Forcing them to upgrade is going to put extra load on our team 😉
from phinx.
Why not backport to 0.14 only? Shouldn't be any need to still use 0.13 afaik
See wiki
from phinx.
Thanks for all the feedback!
I'm stuck with 0.13 because a large number of deployments of our application are still on PHP 7.4, we could move to 0.14.
from phinx.
0.14 backport is fine, even supporting 7.4 here totally OK, no worries. Thats still the min version for the Cake4 series.
A backport PR would be welcome here.
from phinx.
I'll see whether I can find the time to look into the backport in the short term. If someone who's more familiar with the package is willing to look into this, that's obviously more than welcome! 🤞
from phinx.
Same for me. At the moment we have to support PHP 7.4 because it is part of Ubuntu 20.04 which is still in support until Apr 2025. Even if PHP 7.4 itself is EOL.
from phinx.
Related Issues (20)
- Argument #2 ($version) must be of type ?int, string given HOT 3
- Support for testing "outer" config HOT 1
- getQueryBuilder and documentation for 0.15? HOT 2
- [0.15.3] Cannot migrate to a specific target with -t HOT 2
- Are tables with SYSTEM VERSIONING (available in MariaDB v10.3+) supported? HOT 1
- Set default value of a column to unhex(replace(uuid(),'-','')) HOT 4
- Does Phinx support '%%PHINX_%%' variables for environment ports? HOT 2
- Validate version int range
- Support Symfony Console 7.0 HOT 2
- Unable to use `Literal` as column type
- Native uuid type for mariadb
- Support enums in postgres HOT 5
- Automatically add update triggers for postgres updated_at columns
- warning no environment specified, defaulting to: development HOT 4
- Argument --version does not display version HOT 3
- Integers without signed declarations must be unsigned by default
- RenameColumn generating SQL syntax
- (At least) Non-interactive commands should write errors to STDERR
- Documentation needs updating HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phinx.