Comments (3)
Per conversation with @Leo6Leo:
git make-pr -r <remote_name: defaults to upstream>
-u <remote_url: if provided, overrides -r>
-s <: whether or not to stash any uncommited changes>
-c <commit_message: commit uncomitted but staged changes with commit_message>
from git-utils.
If -s
and -c
are provided, it will:
- commit any staged changes
- stash any remaining changes
If after following this resolution process there are any remaining unstashed/uncommitted changes the command will fail. @Leo6Leo do you think we should also add a -f
flag which will force the command to make the PR even if there are remaining unstashed/uncommited changes?
from git-utils.
If
-s
and-c
are provided, it will:
- commit any staged changes
- stash any remaining changes
If after following this resolution process there are any remaining unstashed/uncommitted changes the command will fail. @Leo6Leo do you think we should also add a
-f
flag which will force the command to make the PR even if there are remaining unstashed/uncommited changes?
I think it's generally advised to ensure that there are no uncommitted/unstashed changes before making a PR. This is to make sure that the changes being proposed are clear, complete, and can be easily reviewed and tested by others.
But things happens sometimes, adding a -f flag (force flag) could potentially be useful, but it should be used with caution. We might need to highlight the potential risks involved in using this flag (like causing confusion for reviewers or even introducing bugs if the changes are not fully ready), and it should generally be discouraged unless there's a clear need for it. @Cali0707
from git-utils.
Related Issues (20)
- Add Gitlab support to git clonefork HOT 1
- Update install script to verify if jq is installed
- Add cases for repos that has main branch named "master" in upstream for git sync HOT 1
- Make more welcoming to contributions HOT 3
- Support no local checkout of main/master branch in git sync
- Missing bin path
- Auto create fork repo with GitHub API HOT 2
- Design the issue template on GitHub HOT 2
- Write CONTRIBUTING.md
- Handle clonefork errors more gracefully
- Github SSH key setup
- [Proposal]: Checkout PR command HOT 6
- Make README look better
- Support non-git url in git clonefork HOT 1
- Make base git make-pr command
- Optionally stash changes in git make-pr
- Add commit option to make-pr
- Add remote option to git make-pr
- Support non forked repos in `git-sync`
- More detail in the installation error description
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-utils.