Giter Site home page Giter Site logo

Make PR command about git-utils HOT 3 OPEN

Cali0707 avatar Cali0707 commented on August 17, 2024
Make PR command

from git-utils.

Comments (3)

Cali0707 avatar Cali0707 commented on August 17, 2024

Per conversation with @Leo6Leo:

git make-pr -r <remote_name: defaults to upstream>
            -u <remote_url: if provided, overrides -r>
            -s <: whether or not to stash any uncommited changes>
            -c <commit_message: commit uncomitted but staged changes with commit_message>

from git-utils.

Cali0707 avatar Cali0707 commented on August 17, 2024

If -s and -c are provided, it will:

  1. commit any staged changes
  2. stash any remaining changes

If after following this resolution process there are any remaining unstashed/uncommitted changes the command will fail. @Leo6Leo do you think we should also add a -f flag which will force the command to make the PR even if there are remaining unstashed/uncommited changes?

from git-utils.

Leo6Leo avatar Leo6Leo commented on August 17, 2024

If -s and -c are provided, it will:

  1. commit any staged changes
  2. stash any remaining changes

If after following this resolution process there are any remaining unstashed/uncommitted changes the command will fail. @Leo6Leo do you think we should also add a -f flag which will force the command to make the PR even if there are remaining unstashed/uncommited changes?

I think it's generally advised to ensure that there are no uncommitted/unstashed changes before making a PR. This is to make sure that the changes being proposed are clear, complete, and can be easily reviewed and tested by others.

But things happens sometimes, adding a -f flag (force flag) could potentially be useful, but it should be used with caution. We might need to highlight the potential risks involved in using this flag (like causing confusion for reviewers or even introducing bugs if the changes are not fully ready), and it should generally be discouraged unless there's a clear need for it. @Cali0707

from git-utils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.