Giter Site home page Giter Site logo

Comments (4)

robmorieson avatar robmorieson commented on May 29, 2024 4

@altaywtf thanks for the gentle bump — this one did fall off the radar so very much appreciated.

Happy to report that a fix for this issue has now been merged and a patch release will be going out including the fix in the next few days.

from react-live-chat-loader.

nzjames avatar nzjames commented on May 29, 2024

I built the main branch using node 14 and I found the dist/ and module/ outputs transpiled closer to the output of v2.7.4.

Looking at .babelrc I suspect having the targets set to node

"@babel/preset-env",
{
  "targets": {
    "node": true
  }
}

and having the .tool-versions specify

nodejs 16.15.0

results in the output bundles being transpiled to node 16 which supports optional chaining so this is left in.

I'm not an expert in this space but would changing the targets to something like:

"@babel/preset-env",
{
  "targets": {
    "browsers": "last 2 versions"
  }
}

provide a generated output that is safer to use in browser?

from react-live-chat-loader.

robmorieson avatar robmorieson commented on May 29, 2024

Hey @nzjames, thanks for raising this one.

We were able to replicate the bug following the steps provided. It seems like the cause of the issue was likely a bump in the @babel/core dependency, as nothing changed in .tool-versions or .babelrc between 2.7.4 and 2.8.0.

Your solution above looks good to me (thanks for that!), so we’ll shoot to get a patch release with the fix rolled out shortly. Cheers!

from react-live-chat-loader.

altaywtf avatar altaywtf commented on May 29, 2024

hey there @robmorieson!

first of all, thank you so much for the great work. we truly appreciate it 🙏

I hate to be that person but, 😭 are there any updates regarding this issue? 😭

we had to manually transpile react-live-chat-loader via our webpack config as a workaround, but that's a bit suboptimal.

from react-live-chat-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.