reading array element outside of the size

[caligatio]

reading array element outside of the size

[Caligatio]

What browser and version are you using that you're hitting this issue?

[serge-pouliquen-itf]

Currently, I'm using icedove 24.x branch with javascript.options.strict set to true.
In Future, I'm planning to use your lib in GVP 6.5 which is compatible only with strict mode (another project).

[Caligatio]

This is actually a kind of a pain because I don't know the proper length ahead of time because of the nature of Unicode characters.

I can add a bit of logic that will use append if I hit a byteCnt % 4 == 0. I can try it this weekend.

[Caligatio]

This should be fixed now in https://github.com/Caligatio/jsSHA/blob/60a1074c2ff89d4b24f8de3f0ef50233ed2db738/src/sha_dev.js

Can you try it to see if it still spits out warnings/errors?

[serge-pouliquen-itf]

Hi,
I tried the link and got an error.

Avertissement : ReferenceError: reference to undefined property message[(messageLen >>> 5)]
Ligne : 989

[Caligatio]

OK so I think I now fully understand what's going on now. Apparently someone in the JavaScript world that assigning to array indexes greater than their current size is allowed but reading from an out of bounds array index is bad. I do bitwise |= all over the place so there were a lot of problems.

I think I managed to track down all the locations in https://github.com/Caligatio/jsSHA/blob/6e416b913a4efc228543f8107aaff3f471e1ec5a/src/sha_dev.js (I flipped Firefox into strict mode and found the problems as I spotted them). If you could try it one more time, I think there shouldn't be any more warnings.

[serge-pouliquen-itf]

There is no warning for me.
Thanks a lot