Data object not getting assigned for anything not json

[capacitor-community]

Data object not getting assigned for anything not json

[andysousa]

I had started putting together the fix for this to submit a PR and got pulled into a few different directions. I will see if i can get to it and share with you to test out. Not sure if @mlynch is still doing active dev on this.... but would be a quick fix.

[pixelbucket-dev]

Same problem here. We're trying to do a auth0 request via iOS implementation. The response returns with

data: Object
    error: "invalid_request"
    error_description: "grant_type is required"

[pixelbucket-dev]

Our request looks like this

return Http.request({
    method: 'POST',
    url: 'SOME_ENDPOINT',
    headers: {
      'Content-Type': 'application/x-www-form-urlencoded'
    },
    data: {
        username,
        password,
        grant_type: 'password',
        client_id: 'SOME_CLIENT_ID',
        client_secret: 'SOME_CLIENT_SECRET'
    }
});

[pixelbucket-dev]

Thanks @andysousa , really appreciated.

[mlynch]

PR welcome if you have something soon, if not I can take a look in a few days

[andysousa]

I have the web and android one working, but my swift is just not that strong. Maybe you could tell me where to look @mlynch?

This is where the data should be getting set in the mutate function, but that is always nil

func mutate(_ call: CAPPluginCall, _ url: URL, _ method: String, _ headers: [String:String]) {
    let data = call.getObject("data")
    

[mlynch]

@andysousa can you open a PR with the android/web changes and then I can help figure out where the Swift side should happen? Thanks 🙌

[andysousa]

@mlynch i was mistaken, android wasn't working for me either. The CAPPluginCall just doesn't have an object called "data" in it for ios/Android. Guessing thats happening at the Cap runtime level... but haven't dug in yet.

[andysousa]

oh, i see the issue... data is being set with getObject... but for OAuth calls, it needs to be getString(). Not sure the downstream ramifications of this... let me see if i can put something together.

[andysousa]

so using a data object for OAuth works in ios/android... the code is smart enough to check the content type and put it as part of the object correctly. This doesn't work the same in the web implemention, so i will submit a PR so that the web matches the logic in ios/Android.

In the meantime @pixelbucket-dev to for it to work in Native, all you need to do is put the data in an object block. The code you pasted won't work because in OAuth, the body should be one string. So you would want to do this.

   const ret = Http.request({
      method: 'POST',
      url: '/api/auth/connect/token',
      headers: {
        'Content-Type': 'application/x-www-form-urlencoded',
      },
      data: {
        body: "username=username&password=password&grant_type=password&client_id=something&clientsecret=something"      
      }
    });

[andysousa]

@pixelbucket-dev I was wrong, as i dig deeper into the ios implementation... the way you have it should work, its is doing a queryItems?.append so it will build the string appropriately.

I also don't like my implementation in the PR based on this. So i am going to go back and clean it up.

[andysousa]

ok, PR updated... give that a spin

[pixelbucket-dev]

@andysousa I had a look at the TS code, looks good.

I remember when I tested our request with this plugin I saw the query params being correctly stringified. Might try again with your body workaround. Thank you.