Removing attributes from User schema

[captain-p-goldfish]

Removing attributes from User schema

[Captain-P-Goldfish]

Hi,
the way of overriding the user schema easier to understand in my eyes. If another developer looks into your code in two years it might be easier to understand that a custom schema is used if you copy and modify it. That is why I was suggesting doing so. Removing the attributes during runtime should also work though. Could you please explain the behaviour that you are experiencing?
It should be possible to remove attributes directly from the de.captaingoldfish.scim.sdk.common.schemas.Schema class and the change should take effect immediately.

[petersondrew]

Hmm, I was using getMainSchema of the User resource type I had registered, and when I would call removeAttribute, the attribute would still appear when calling the /Schema endpoint.

I understand your suggestion on copying and modifying, I was concerned that maintainers might be confused by the User resource in the library compared to the custom OtherUser resource we'd be maintaining ourselves, so that's why I was experimenting with the runtime modifications.

[Captain-P-Goldfish]

I was just trying the following:

    ResourceType userResourceType = resourceEndpoint.registerEndpoint(new UserEndpointDefinition(new UserHandler()));
    userResourceType.setFeatures(ResourceTypeFeatures.builder().autoFiltering(true).autoSorting(true).build());

    Schema mainSchema = userResourceType.getMainSchema();
    SchemaAttribute ims = mainSchema.getSchemaAttribute(AttributeNames.RFC7643.IMS);

and the /Schemas-Endpoint was no longer returning the ims -attribute. I you found a problem that causes the Schemas endpoint to return erroneous values please let me know but currently I cannot reproduce this problem.

I think this is also a perfectly fine and valid way of doing this if properly documented :-)

[petersondrew]

This was definitely my misunderstanding of the API. I was using remove and passing a property name that likely was not one of the constant values. Your example above cleared everything up, thanks so much!