Giter Site home page Giter Site logo

Comments (6)

nstuyvesant avatar nstuyvesant commented on June 19, 2024

@finken2 - what bundler are you using?

What happens if you do...

@use '@carbon/charts/scss'

or

@use '@carbon/charts/scss/index.scss'

from carbon-charts.

finken2 avatar finken2 commented on June 19, 2024

We're using webpack. The first one fails the same way, but the 2nd one does work. A little weird to need to the index.scss there, but at least it works. I tried like 100 different approaches, and i swear that was one of them, but who knows. Thanks for the suggestion.

I started this conversation on Slack by asking "what's the recommended way to load styles in 1.x?" and was directed to open an issue. We should get the docs updated to whatever the expected working approach is. I doubt i'm the only one who got tripped up by the change between versions.

from carbon-charts.

nstuyvesant avatar nstuyvesant commented on June 19, 2024

Webpack is finicky about resolving paths and it's unfortunately not good at using the modern conventions for package.json exports.

There is a new docs website in a PR under review. I just added the reference for this file to it.

BTW... if you have an option to use vite instead of webpack, I think you'll find it's faster and requires less configuration.

from carbon-charts.

crhuff-ibm avatar crhuff-ibm commented on June 19, 2024

To add on to this, I'm trying to install just @carbon/charts-react and not both /charts and /charts-react. When installing the charts-react styling using @import '@carbon/charts-react/styles.css'; it works but again, the goal is to use use not import.

I think the issue here may come from having the exports mapping to the dist/ directory, because in our component library we bundle and ship the styles.css file without being explicit on exports, and are able to use @use '@our/package/styles' and don't have to specify .css or import

from carbon-charts.

crhuff-ibm avatar crhuff-ibm commented on June 19, 2024

We also can't re-write our entire bundler just to solve this one issue.

Additionally, looking at the docs out right now it includes the following for Getting started

import { StackedBarChart } from '@carbon/charts-react'
import '@carbon/charts-react/styles.css'

We can't really be expected to import .css files directly into our code in 2024 and not put into our styling tree right?

from carbon-charts.

nstuyvesant avatar nstuyvesant commented on June 19, 2024

To add on to this, I'm trying to install just @carbon/charts-react and not both /charts and /charts-react. When installing the charts-react styling using @import '@carbon/charts-react/styles.css'; it works but again, the goal is to use use not import.

I think the issue here may come from having the exports mapping to the dist/ directory, because in our component library we bundle and ship the styles.css file without being explicit on exports, and are able to use @use '@our/package/styles' and don't have to specify .css or import

Only @carbon/charts publishes the SCSS unfortunately so if you want to use @use with an SCSS file, you would need to do

@use '@carbon/charts/scss/index.scss';

There are two exports in package.json for the same file. See https://github.com/carbon-design-system/carbon-charts/blob/master/packages/core/package.json#L13 (and line 14).

The @carbon/charts package.json has no SCSS exports pointing to the dist directory - only CSS.

from carbon-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.