getlink doesn't prevent parameter from being eliminated by optimization

[cardillan]

getlink doesn't prevent parameter from being eliminated by optimization

[cardillan]

I'm completely new to ANTLR, but perhaps the problem is in the DeadCodeEliminator class, where instead of this

    private void visitGetlink(LogicInstruction instruction) {
        reads.add(instruction.getArgs().get(0));
    }

should be

    private void visitGetlink(LogicInstruction instruction) {
        addWrite(instruction, 0);
        reads.add(instruction.getArgs().get(1));
    }

as the getlink instruction syntax is getlink out index

[francois]

You are most likely right. I have not looked at the code in a long while. Can you provide a PR for this? Thanks!FrançoisLe 5 janv. 2023 à 06:26, cardillan ***@***.***> a écrit : I'm completely new to ANTLR, but perhaps the problem is in the DeadCodeEliminator class, where instead of this private void visitGetlink(LogicInstruction instruction) { reads.add(instruction.getArgs().get(0)); } should be private void visitGetlink(LogicInstruction instruction) { addWrite(instruction, 0); reads.add(instruction.getArgs().get(1)); } as the getlink instruction syntax is getlink out index —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[cardillan]

I verified the change locally -- I got the expected result, and I've created the pull request. It's my first one, so I hope I didn't mess up anything. It looked okay-ish to me.