Rendering OCKInsightsChartTableViewCell causes lags

[carekit-apple]

Rendering OCKInsightsChartTableViewCell causes lags

[brynbodayle]

@umerkhan-apple Any thoughts on a way to tackle this?

I've been investigating and there doesn't seem to be an easy fix. The preparation and recreation of the OKGroupedBarChartView takes quite a long time and occurs every time cellForRowAtIndexPath is called so the scrolling really lags a lot. I've been testing on an iPod Touch 5g.

A few options I thought of, but not sure what the requirements are for the OKGroupedBarChartView are.

1. Separate each of the components of the OKGroupedBarChartView into different UITableViewCells. So one cell for the title label, one cell for each of the bars, and one cell for the legend. This would allow each of these components to be reused as you scroll. It would also simplify the constraints for the cells, which is part of the reason it's taking a while to prepare. The major downside to this approach is it's a bit more complex, and you don't have a reusable OKGroupedBarChartView.
2. Add more caching for the OKGroupedBarChartView and reuse the views more, as opposed to recreating them every time. My hesitancy to this approach is that I'm not sure if it's possible to achieve optimal performance since these bar charts are pretty CPU-bound.

[YuanZhu-apple]

Separate each of the components of the OKGroupedBarChartView into different UITableViewCells. So ?one cell for the title label, one cell for each of the bars, and one cell for the legend. This would allow each of these components to be reused as you scroll. It would also simplify the constraints for the cells, which is part of the reason it's taking a while to prepare. The major downside to this approach is it's a bit more complex, and you don't have a reusable OKGroupedBarChartView.

This would be really complex.

Add more caching for the OKGroupedBarChartView and reuse the views more, as opposed to recreating them every time. My hesitancy to this approach is that I'm not sure if it's possible to achieve optimal performance since these bar charts are pretty CPU-bound.

This could be the way to go. Quick workaround would be create a custom OCKBarChart subclass which support chartview caching.

Also can you share with us how many bars on each of chart?

[brynbodayle]

This could be the way to go. Quick workaround would be create a custom OCKBarChart subclass which support chartview caching.

Ah, I'll try this then.

I'm just looking at the test app, which has two charts, 7 bars each.

[mikehouse]

Caching is a great idea. I tried it out when I found this issue and it worked perfect... but the first instantiation anyway lasts too long. Thanks!

[akshay-yadav-apple]

Hey @mikehouse !
Do you need further assistance with this issue?

[mikehouse]

Hello, @akshay-yadav-apple, this issue is all yours :). Past time I was busy and didn't push changes to fix this. Now I even don't remember what it was about. Thanks.

[Pariecemckinney-apple]

Closing due to inactivity. Please feel free to reopen if you would like the conversation to continue.