binstall tries to build for x86_64-unknown-linux-musl instead of x86_64-unknown-linux-gnu

[tyilo]

binstall tries to build for x86_64-unknown-linux-musl instead of x86_64-unknown-linux-gnu

[NobodyXu]

Thanks for the feedback @JCallicoat @tyilo

I will also add PR for lib64 glibc and fallback to cargo without the --target

[NobodyXu]

Is there a reason for not always using the same target as cargo install does?

On NixOS, there isn't a global libc in /lib, the glibc is put in a different location as a separate nix package.

If someone installed rustc on NixOS with glibc, the rustc -vV will give x86_64-unknown-linux-gnu, however downloaded gnu binaries cannot run due to missing libc.

[JCallicoat]

I was about to post about this same issue. I checked on arch and fedora37 - 39/rawhide and they all have the vanilla GNU libc instead of ubuntu's GLIBC in the ld-linux output, but I just saw @NobodyXu fixed that in 104b399.

Another problem is that fedora ld-linux is under /lib64/ld-linux-x86-64.so.2 / /usr/lib64/ld-linux-x86-64.so.2 so it would not be found by the three locations here.

cargo-binstall/crates/detect-targets/src/detect/linux.rs

Lines 44 to 46 in 86060fa

	format!("/lib/ld-linux-{cpu_arch_suffix}.so.2"),
	format!("/lib/{cpu_arch}-linux-gnu/ld-linux-{cpu_arch_suffix}.so.2"),
	format!("/usr/lib/{cpu_arch}-linux-gnu/ld-linux-{cpu_arch_suffix}.so.2"),

[tyilo]

It seems to me that the target for building shouldn't necessarily be the same as for downloading.
For building it should always be a target that is installed, otherwise it would fail anyway. So if the user only has one of musl and gnu targets, that target should always be picked no matter what the detection algorithm determines.

[NobodyXu]

Thanks, I will submit a fix for this shortly.

It is surprising how glibc from different distro behaves so differently.

[tyilo]

Is there a reason for not always using the same target as cargo install does?

[tyilo]

Shouldn't a user of such as system configure cargo to use x86_64-unknown-linux-musl as the default target?

[NobodyXu]

@tyilo Opened #1430 for your idea