Comments (12)
I don't understand exactly what is the problem. 1.4.1 is the latest release for jquery.cookie. js-cookie started from js-cookie/js-cookie@4527b37 up to the version 1.5.0, which contains everything this repo has, except the notices.
- The problem with hard reset is that it will break forks.
- Releasing a new version doesn't seems to make sense because everything here is contained in the version 1.5.0 anyway.
Btw, the master branch should not be used in production because it is, by default, an unstable branch. The only version that should be considered here is the ones that were released up to 1.4.1.
from jquery-cookie.
I'm not suggesting a new release. I'm suggesting that either the "master" branch of this project roll-back to the 1.4.1 release, or that the files be tagged "1.4.2-dev" (but no new release made).
The reason is because the master branch is not actually "1.4.1" -- it has a lot of commits since then, but the repo's design makes it look like master is 1.4.1. I
from jquery-cookie.
The reason is because the master branch is not actually "1.4.1"
Now I got it, it can be confusing for people that copies the code directly from the source without checking the releases page. Is that it?
from jquery-cookie.
So you expect the master branch to practically match a release, like in the git flow model?
from jquery-cookie.
@FagnerMartinsBrack yes. If someone looks at this repo and says "ok, let's just see what the last update here is..." then looks at the file, they get the unreleased version not the actual 1.4.1
@carhartl I'm a fan of that model, but not expecting it. Many projects might use a "-dev" or other placeholder version in their master branch, or bump the version number up to the forthcoming release. This repo is weird/misleading because there is a "1.4.1" tag, but the "master" branch used for development has files labeled "1.4.1" as well. It suggests that the master and the tag are the same, but master is many commits ahead.
from jquery-cookie.
I am convinced that changing the version number to 1.4.2-unreleased
or 1.4.2-frozen
for all relevant files in master (without publishing it on npm) is a reasonable request to prevent further confusion.
@carhartl what do you think?
from jquery-cookie.
@jvanasco sorry to take too long, here is the Pull Request, care to take a look?
from jquery-cookie.
I still haven't unterstood up to this day what the problem is.
from jquery-cookie.
I still haven't unterstood up to this day what the problem is.
Basically if he goes to the Releases page it says:
39 commits to master since this release
This will make one to assume that there were additional important fixes on this repository after 1.4.1 which weren't released with 1.4.1. We know it is not the case and all commits went to the new repo, but those ending up here don't know that. Since most people jump straight to the version in the source file or json metadata to check the actual version, 1.4.2-unreleased
provides a clear hint that the commits belong to a non released version 1.4.2.
Other solution is to create an actual new 1.4.2 release and publish on npm so that master
is not too far away from the latest release.
@jvanasco please correct me if I am wrong.
from jquery-cookie.
@carhartl @jvanasco I will leave #388 open, if there is no feedback for a few days I will just merge it to close this issue, then we can monitor if anybody else will have this kind of problem in the future.
Does that makes sense?
from jquery-cookie.
Looks good.
That's a good distillation of the confusion.
Also, If you search online for the latest version, you'll end up seeing the current master which is really "1.4.2-unreleased" and not 1.4.1 as labeled. So it can be confusing to see what version is really running -- especially if junior devs are checking in the file.
On Mar 4, 2016, at 6:12 AM, Fagner Brack [email protected] wrote:
I still haven't unterstood up to this day what the problem is.
Basically if he goes to the Releases page it says:
39 commits to master since this release
This will make one to think that there were additional important fixes on this repository after 1.4.1 which weren't released with 1.4.1. We know it is not the case and all commits went to the new repo, but those ending up here don't know that. Since most people jump straight to the version in the source file or json metadata to check the actual version, 1.4.2-unreleased provides a clear hint that the commits belong to a non released version 1.4.1.
Other solution is to create an actual new 1.4.2 release and publish on npm so that master is not too far away from the latest release.
—
Reply to this email directly or view it on GitHub.
from jquery-cookie.
It seems this s going nowhere, as from this comment.
I have added the following to the version 1.4.1 in the releases page, I hope this at least clarifies for those who don't read the README and go straight to the releases page:
Note:
This is the last version on this repository. To see all the versions, check the new repository.For more information, see this comment.
from jquery-cookie.
Related Issues (20)
- If the cookie time is up, then the cookie value is what? undefind or null? HOT 1
- Line Break HOT 1
- Line Break HOT 9
- [NuGet] Align naming convention between minified and base .js files in package HOT 2
- $.removeCookie is not deleting cookie in Chrome HOT 13
- A Session Cookie not working HOT 8
- Cookies deleted when page open without query parameters HOT 2
- $.removeCookie is not a recognized on Chrome HOT 7
- Cookie gets restored magically after some time HOT 7
- Disable issues? HOT 2
- Escape # char
- Cookie not set in IE10 HOT 1
- Do not create an issue here! HOT 3
- Bower crashing if using jquery-cookie 1.4.1 HOT 2
- Unable to install using Bower HOT 6
- Fail update cookie? HOT 2
- jquery cookie support for http flag true HOT 2
- Cookie Https HOT 2
- suggestion: add function for parse signedcookies in next rev HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jquery-cookie.