Comments (5)
+1 for this. Tried running this on an Ubuntu 14.04 server (with python 2.7.6) and it did not work.
from python-github-webhooks.
@PHLAK: If you want a quick kludge, just replace "hmac.compare_digest(str(mac.hexdigest()), str(signature))" with "str(mac.hexdigest()) == str(signature)" and it'll work fine.
from python-github-webhooks.
Sounds about right. @kpriceyahoo could you please prepare a merge request?
Thanks.
from python-github-webhooks.
I went with a modified version of option 2 and just enabled the fallback automatically based on the Python version. Since the secret feature is unusable for earlier versions of python otherwise, I don't see any reason to add the option.
from python-github-webhooks.
@kpriceyahoo great, I was about to recommend the same. Thanks.
from python-github-webhooks.
Related Issues (9)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-github-webhooks.