Giter Site home page Giter Site logo

Comments (12)

tracykteal avatar tracykteal commented on May 26, 2024 3

As a note, I think we should keep the 'hide' option. It's good for the 'solutions'. It just seems less useful for the 'challenge' and maybe also 'discussion'.

You can see what this looks like at the bottom of this lesson
http://www.datacarpentry.org/sql-ecology-lesson/03-sql-joins-aliases/

from lesson-example.

tbekolay avatar tbekolay commented on May 26, 2024 1

I'm also +1 for challenges shown by default and solutions hidden by default.

Not to veer too off-topic, but it might also be nice to provide a "show / hide all challenges" link to show or hide all challenges at once.

from lesson-example.

rgaiacs avatar rgaiacs commented on May 26, 2024

With the challenges being click to open, there has been some confusion about where the challenges are until people realize they need to click on the arrow.

I don't have any training in user experience/user interface so I can't what we should use and I fail to locate the issue where I and @gvwilson talked about hide or not the challenges and other call out boxes. What I remember is that the decision to hide challenges and call out boxes was to not "distract" self-learners and workshop attendees from the main lesson/text.

Should that be the default behavior in the template?

I think that all Carpentry lessons should have the same fell. We should hide challenges in all or don't do it in any.

If people prefer to have un-hide challenges by default I would request to un-hide all the call out boxes for sake of consistence and reduce our code base.

from lesson-example.

tracykteal avatar tracykteal commented on May 26, 2024

Thanks @rgaiacs then I would advocate for unhiding them by default. In discussion sections we've had people mention it as an issue. Since they already look separate in their box, they don't seem to be a distraction in the flow of reading. Happy to put in a PR if this is the decision.

from lesson-example.

rgaiacs avatar rgaiacs commented on May 26, 2024

Happy to put in a PR if this is the decision.

I can do the PR but I want to ask more people about their preferences. I will copy you on the email.

from lesson-example.

gdevenyi avatar gdevenyi commented on May 26, 2024

I'm okay with show by default with a hide button

from lesson-example.

orchid00 avatar orchid00 commented on May 26, 2024

I like to show challenges by default and hide solutions by default. The aliases example looks good @tracykteal

from lesson-example.

gcapes avatar gcapes commented on May 26, 2024

I think the solutions should be within the challenge callout box - as they currently are. This looks neater. The SQL lesson has them as a separate box.

I don't feel strongly about whether the question is shown or hidden by default, or whether it is hidable at all.

from lesson-example.

tracykteal avatar tracykteal commented on May 26, 2024

You're right it is better to have them together and agree that should be the default. I put in a PR. That update is viewable here http://tracykteal.github.io/sql-ecology/03-sql-joins-aliases/

PR is merged, so the example has the solution in the same box as the challenge.

from lesson-example.

naupaka avatar naupaka commented on May 26, 2024

I'm +1 for challenge shown by default and answers to challenges hidden by default.

from lesson-example.

rgaiacs avatar rgaiacs commented on May 26, 2024

So far the we have

Show by default (with questions hide)

Resolution

I'm sending a pull request soon.

from lesson-example.

rgaiacs avatar rgaiacs commented on May 26, 2024

Close by #120.

from lesson-example.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.