Comments (7)
I'm not sure what you mean. That regexp is for valid import locations and there is no valid observable
location in v6 without rxjs-compat
.
I'll have a look at the ignored import 'rxjs-compat/add/observable/of
a little later.
from rxjs-tslint-rules.
Ahh right, I see that now 🤦♂.
Then I'm not sure why it is ignoring it.
Our current workaround is to add 'rxjs-compat' into the import-blacklist which is working for now so no rush.
from rxjs-tslint-rules.
I added a test to attempt a reproduction of the issue, but the test passes, so ... 🤷♂
See 4c67962
from rxjs-tslint-rules.
For the test should the import not be import 'rxjs-compat/add/observable/of';
?
Or am I misunderstanding how these tests work?
from rxjs-tslint-rules.
You've misunderstood. You use the old-style imports when using rxjs-compat
. You should never have rxjs-compat
in the import location. If you have a look in node_modules/rxjs
you will find files in the places for the old import locations and those re-direct to rxjs-compat
.
from rxjs-tslint-rules.
Ahhh ok cool, thanks for taking the time looking into this 😄 and sorry for any wasted time
from rxjs-tslint-rules.
No worries.
from rxjs-tslint-rules.
Related Issues (20)
- False positive for rxjs-no-unsafe-scope on parameter type HOT 1
- ESLint port? HOT 1
- rxjs-no-ignored-observable not working? HOT 1
- rxjs-no-create is not working without type information HOT 4
- rxjs-no-redundant-notify is too simplistic HOT 4
- Deprecated rules? HOT 3
- Changlog has incorrectly named rules. HOT 1
- Whitelist class property in rxjs-finnish based on decorator HOT 3
- Support for untilDestroyed alias in rxjs-no-unsafe-takeuntil HOT 8
- Support for class inheritance on rxjs-prefer-angular-takeuntil HOT 3
- Subscribing without takeUntil is forbidden (rxjs-prefer-angular-takeuntil) when take(1) is added HOT 1
- Not so opinionated analog of `rxjs-prefer-angular-takeuntil`, please HOT 9
- Allow DOMExceptions with rxjs-throw-error HOT 2
- Feature Request > Remove RxJS as a Peer Dependency HOT 3
- False positive prefer-angular-composition with unsubscribe in super class HOT 1
- [Request] rxjs-prefer-angular-composition for services. HOT 2
- rxjs-prefer-angular-takeuntil doesn't work with param "this" HOT 1
- [Request] Define a new rule to enforce to have catchError operator HOT 2
- shareReplay is forbidden unless a config argument is passed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rxjs-tslint-rules.