Carry annotations from interface into generated implementation

[stoyicker]

Carry annotations from interface into generated implementation

[JakeWharton]

Ok! It's not that urgent. There's three whole days left this week, and Monday would be fine, too.

[JakeWharton]

We can special case individual Dagger annotations like @Reusable, although I thought support for that was removed from Dagger a while ago.

[stoyicker]

The javadoc of the latest version seems to still include it, but I don't keep up much with the latest of the Dagger community, so I don't really know.
I'll see what I can come up with for a pr and report back, thanks

[JakeWharton]

I was thinking of releasable references, not reusable.

…

On Tue, Nov 10, 2020, at 10:17 AM, Jorge Antonio Díaz-Benito Soriano wrote: The javadoc of the latest version seems to still include it <https://javadoc.io/static/com.google.dagger/dagger/2.29.1/dagger/Reusable.html>, but I don't keep up much with the latest of the Dagger community, so I don't really know. I'll see what I can come up with for a pr and report back, thanks — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#158 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAQIENVHMGYD4AQHBKFCJDSPFKRFANCNFSM4TQOISOQ>.

[JakeWharton]

I would like to do a release this week. Let me know how you are progressing and if you want me to take over. We can start with just special casing that annotation.

[stoyicker]

I have a patch half-way through for annotations in dagger.* packages. Just need to add/update some tests but I'm afk right now, I'll have it ready in a few hours

…

On Tue, 10 Nov 2020, 20:50 Jake Wharton, ***@***.***> wrote: I would like to do a release this week. Let me know how you are progressing and if you want me to take over. We can start with just special casing that annotation. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#158 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANHCRYXQH2WIL6VFP7CLI3SPGKQZANCNFSM4TQOISOQ> .