Giter Site home page Giter Site logo

Comments (4)

JakeWharton avatar JakeWharton commented on June 28, 2024

Seems like DbManager is missing a use statement to close whatever resource it uses. Either a full DB or just a query. It's not clear.

from sqldelight.

samuelprince77 avatar samuelprince77 commented on June 28, 2024

In my case DbManager is just a wrapper for db operations, something like this:

class DbManager(
    private val context: Context
) {

    private val database: MyDatabase by lazy {
        val sqlDriver: SqlDriver = AndroidSqliteDriver(
            callback = MyMigrationCallback(),
            context = context,
            schema = MyDatabase.Schema,
            name = DATABASE_NAME,
        )

        MyDatabase(driver = sqlDriver)
    }

    suspend fun someDbOperation(): List<Something> = withContext(Dispatchers.IO) {
        database.myQueries.requestForSomeData().executeAsList()
    }

}

from sqldelight.

JakeWharton avatar JakeWharton commented on June 28, 2024

So you're leaking the whole database there. You should open it once and share it throughout the app's process lifetime. Or, if you must have it scoped to a worker, close it when the work is done.

from sqldelight.

samuelprince77 avatar samuelprince77 commented on June 28, 2024

Ah! Alright! That makes sense, thanks for the help

from sqldelight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.