some boolean expressions no longer compile

[lnhrdt]

some boolean expressions no longer compile

[griffio]

👻 Looks like missing the type from SqlBinaryExpr

sqldelight/dialects/postgresql/src/main/kotlin/app/cash/sqldelight/dialects/postgresql/PostgreSqlTypeResolver.kt

Lines 237 to 248 in da8c744

	SMALL_INT,
	PostgreSqlType.INTEGER,
	INTEGER,
	BIG_INT,
	REAL,
	TEXT,
	BLOB,
	PostgreSqlType.INTERVAL,
	PostgreSqlType.TIMESTAMP_TIMEZONE,
	PostgreSqlType.TIMESTAMP,
	PostgreSqlType.JSON,
	PostgreSqlType.TSVECTOR,

Can be fixed by adding UUID and probably some more missing types but needs to have table interface tests

[griffio]

The only thing I would add is that the query above has a syntax error with the comma, that is not valid SQL so not sure how it ran -syntax error at or near "FROM"

Do you have other examples that show a compilation error?

someQuery:
SELECT some_table_1.id AS id,
       some_table_2.id IS NOT NULL AS check_table_2,
       some_table_3.id IS NOT NULL AS check_table_3,
       some_table_4.id IS NOT NULL AS check_table_4, <-- Comma here is not valid in SQL 
FROM some_table_1
LEFT JOIN some_table_2 ON some_table_2.id = some_table_1.id
LEFT JOIN some_table_3 ON some_table_3.id = some_table_1.id
LEFT JOIN some_table_4 ON some_table_4.id = some_table_1.id
WHERE some_table_1.id = :id;

[lnhrdt]

Good catch. I hastily obfuscated my domain from the example and made a couple mistakes in the process. Here's a new example that I've tested demonstrates the issue:

Tables

CREATE TABLE companyRecord (
  id UUID PRIMARY KEY,
  name TEXT NOT NULL
);

CREATE TABLE companyAttributes (
  id UUID PRIMARY KEY REFERENCES companyRecord,
  slogan TEXT NOT NULL
);

Queries

testQuery1:
SELECT companyRecord.id,
       companyRecord.name,
       companyAttributes.slogan IS NOT NULL AS has_slogan
FROM companyRecord
LEFT JOIN companyAttributes ON companyAttributes.id = companyRecord.id
WHERE companyRecord.id = ?;

testQuery2:
SELECT companyRecord.id,
       companyRecord.name,
       companyAttributes.id IS NOT NULL AS has_attributes
FROM companyRecord
LEFT JOIN companyAttributes ON companyAttributes.id = companyRecord.id
WHERE companyRecord.id = ?;

testQuery1 compiles fine. testQuery2 fails to compile with this error:

> A failure occurred while executing app.cash.sqldelight.gradle.SqlDelightTask$GenerateInterfaces
   > Failed to compile PostgreSqlCompoundSelectStmtImpl(COMPOUND_SELECT_STMT): [] :
     SELECT companyRecord.id,
            companyRecord.name,
            companyAttributes.id IS NOT NULL AS has_attributes
     FROM companyRecord
     LEFT JOIN companyAttributes ON companyAttributes.id = companyRecord.id
     WHERE companyRecord.id = ?

The error is not surfaced in IntelliJ through the SQLDelight plugin–it is only shown through compilation.