app crashes after duktape.close() is called

[cashapp]

app crashes after duktape.close() is called

Duktape instances could be called from different threads

Are you sure that nobody is calling the closed instance while or after you close it?

[whkailee]

Hi, I think it's because Duktape.close() is called by the same thread Duktape is running.
I did a simple test and it crashed:

    private void test() {
        runtime = Duktape.create();
        IController controller = new IController() {
            @Override
            public void close() {
                runtime.close();
            }
        };
        runtime.set("controller", IController.class, controller);
        runtime.evaluate("controller.close();");
    }

If I call runtime.close() on another thread, it works fine.

Hmmm, I'd expect that example to crash. The java code is deleting the Duktape VM, and then when you return from controller.close(); you're in a destroyed JS environment.

[whkailee]

That makes sense, to be safe we will always call Duktape.close() on a new thread.