Stack Overflow after 1.2.0, because of shared commit.

[Shabinder]

Stack Overflow after 1.2.0, because of shared commit.

[Shabinder]

[Shabinder]

Thread with all details.
https://kotlinlang.slack.com/archives/C5HT9AL7Q/p1700181390990159?thread_ts=1691432897.694099&cid=C5HT9AL7Q

[Shabinder]

Any update ?

have been stuck on kotlin 1.9.10 and zipline 1.2.0, since above doesnt work. I am more than happy to provide info in any way possible or do a brief sync explaining the steps to repro same.

Case 1: ✅

• Using zipline 1.2.0 host and jsSource both works fine.

Case 2: 🔴

• used zipline 1.8.0 in host(android) and jsSources built with 1.2.0: StackOverflow (looped on below trace)
  • ZiplineServiceAdapterKt.descriptorName refer below image for full trace
    - So this breaks the promise done in readme for 1.x host and binary compatibility ⚠️
    

Case 3: 🔴

• used zipine 1.8.0 for both host and runtime jsBinaries, gave below hard crash
  • Fatal signal 11 (SIGSEGV), code 2 (SEGV_ACCERR), fault addr 0x7b7f130ff8 in tid 30292 (DefaultDispatch), pid 30209 (ndbound.preview) refer below image for full trace

[Shabinder]

After many iteration on finding out what works and what doesnt,

Below Commit is what makes the difference, with commit, plugins are loaded as expected, without, get stackOverflow error as shown.

Shabinder@801b3d6

Shortlisted as much as I could, lmk if I can help or diagnose it more in any other way

[JakeWharton]

So it seems like a type with a recursive descriptor. We can change the calculation to put in a placeholder character for when it recurses by keeping a set of seen types. Will have to try and reproduce, but should be pretty easy give what you've found out so far.

[minteemer]

Got the same exception when using JsonElement as return type of a suspending ZiplineService method:

interface ExampleService : ZiplineService {

  suspend fun example(): JsonElement
}

JsonElement might be JsonArray or JsonObject, which in turn contains List<JsonElement> or Map<String, JsonElement>, thus recursion appears.
A big problem for us, as we wanted to use JsonElement as a return type to get abstract tree of analytics params this way.

This exception does not seem to appear when using JsonElement in return type of non-suspending functions or when using it in function parameters.