Giter Site home page Giter Site logo

Comments (3)

eugeneloza avatar eugeneloza commented on July 17, 2024

No problem :)
But very useful to know, as I'm trying to work with animations loading/processing at the moment. Thanks!

from castle-engine.

michaliskambi avatar michaliskambi commented on July 17, 2024

I fixed the speed loss. And then I discovered that there was no speed loss... so the fix is useless. So the fix is not committed to the CGE master branch (as it makes code a bit uglier, and since it's not needed, it's better to not have it).

Sorry for the noise, looks like there was no need to notify you about this, and there was no need for me to do anything... Well, this wasn't my most productive moment :) Off to sleep now :)

More details:

After I made a fix I tested what the actual speed difference was (lost in e240cc9 and gained again in fab51cb ). And there is no speed difference. Neither there is a difference in memory usage.

Of course, I should have tested this earlier, but I just assumed that e240cc9 was definitely something losing speed or increasing memory usage. It turns out it doesn't matter. The custom "epsilon" in castle-anim-frames is not actually used to gain anything anymore.

The fix is lying for now in https://github.com/castle-engine/castle-engine/compare/use-castle-anim-frames-epsilon branch , but it seems that there's no need to merge it ever to master, so eventually I'll just remove this branch.

from castle-engine.

eugeneloza avatar eugeneloza commented on July 17, 2024

Great! Thanks for notification!

from castle-engine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.