Giter Site home page Giter Site logo

Comments (5)

NiciTheNici avatar NiciTheNici commented on June 3, 2024

bump, this is insanely useful for rockbox users

from onthespot.

NiciTheNici avatar NiciTheNici commented on June 3, 2024

I managed to get this working on my fork. @casualsnek do you think this even needs an option or should it just default to saving the cover art as cover.png all the time like I did in my fork?

https://github.com/NiciTheNici/onthespot/tree/save_cover_as_file

from onthespot.

casualsnek avatar casualsnek commented on June 3, 2024

I managed to get this working on my fork. @casualsnek do you think this even needs an option or should it just default to saving the cover art as cover.png all the time like I did in my fork?

https://github.com/NiciTheNici/onthespot/tree/save_cover_as_file

This being a default behavior won't be too bad as i have seen a lot of media player use it instead of embedded one or using embedded ones only if cover.png is missing !

Good to know you got it working, normally i wold have suggested you to make a PR, but since i am rewriting onthespot all PR and non critical Issue resolution are paused right now. I may make this a default behavior but configurable using the config files in the rewrite.

from onthespot.

artofsound avatar artofsound commented on June 3, 2024

I also have a version that works on my fork, even with a settings option you can tick. I used .jpg tho, because that's what Spotify gives you.
If the file already exists, it skips it.

https://github.com/artofsound/onthespot/tree/cover_image

Screenshot 2023-10-31 093232

from onthespot.

NiciTheNici avatar NiciTheNici commented on June 3, 2024

I used .jpg tho, because that's what Spotify gives you.

Ah I just used png because that's what the method set_music_thumbnail used a few lines above my text. Not unnecessarily converting between formats is probably more efficient...

If the file already exists, it skips it.

Same!

I may make this a default behavior but configurable using the config files in the rewrite.

Sounds perfect! Thanks!

from onthespot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.