Unable to find and assign mission target s_air_term

[tjlaxs]

Unable to find and assign mission target s_air_term

[Vollch]

I can't actually reproduce it, but looking at code i think i see how that's possible.
When game can't find goal it firstly spawn in:

Cataclysm-BN/src/mission_util.cpp

Lines 195 to 196 in 0f77009

	const bool placed = overmap_buffer.place_special( *params.overmap_special, origin_pos,
	params.search_range );

And then searches for exact OMT:

Cataclysm-BN/src/mission_util.cpp

Line 201 in 0f77009

target_pos = overmap_buffer.find_closest( origin_pos, find_params );

(Later on it'll try to spawn special once again, giving second chance to spawn special properly, and dodge debug message)

And here the catch - place_special doesn't accept and process find_params which among other thing specifies min range. So, apparently it's possible that it'll spawn special too close to find it later. That seems to be very old bug.

[chaosvolt]

Dafuq? It's still in the JSON right here: https://github.com/cataclysmbnteam/Cataclysm-BN/blob/upload/data/json/overmap/overmap_special/specials.json#L6890

@Vollch may have done something in their overmap generation code that's causing a scenario mission to no longer be able to find locations, possibly?

[Vollch]

And yeah, i actually reproduced it at x0 specials:

Game spawned 2 airports, but they too close for "min_distance": 45 requirements, which gave me same error.