Seat limit not checked if user already exists

[catalyst]

Seat limit not checked if user already exists

[leonstr]

lib.php explicitly only checks the seat limit if the user doesn't already exist:

188         $user = utils::get_user($client, $username);
189         if (!$user) {
190             // If user doesn't exist create, only when seats are higher then participant count.
191             $tier = new tier($sub->get('tierid'));
192             if ( $sub->get_participant_count() >= (int) $tier->get('seats') ) {
193                 $errorurl = $CFG->wwwroot . '/mod/scormremote/error.php?error=sublimitreached';
194                 header('Content-Type: text/javascript');
195                 exit($OUTPUT->render_from_template('mod_scormremote/init', ['datasource' => $errorurl]));
196             } 
197             $user = utils::create_user($client->get('primarydomain'), $client, $username, $fullname);
198         }

But surely seats used > seat limit isn't the intended behaviour?

[leonstr]

Proposed fix in PR #66.