Giter Site home page Giter Site logo

Comments (3)

catamphetamine avatar catamphetamine commented on August 17, 2024

As far as I can see findNumbers is not part of the original javascript package which is understandable because crawlers and parsers are backend-driven and are therefore written in CPP and Java.
https://github.com/googlei18n/libphonenumber/search?utf8=%E2%9C%93&q=findNumbers&type=
Though I used to code Java a lot in the past, I don't write any crawlers so I don't need that findNumbers function, but if you do you can write it though I'm not sure right now if it's needed in this library.
Given that ES6 brings tree shaking it might not have any impact on other users, but I guess rather than depending on me to publish your code you would prefer instead publishing your code in your own package so that you could be in control if you know what I mean.

from libphonenumber-js.

netanelgilad avatar netanelgilad commented on August 17, 2024

Makes a lot of sense @halt-hammerzeit.
Are the any internal functions/regexes that this library could expose for me to build a package based on this one?

from libphonenumber-js.

catamphetamine avatar catamphetamine commented on August 17, 2024

If you happen to need any (in the final code) then leave a comment here and I'll export them.
Until you're ready to publish you can copy&paste them (i modified some of them a bit, btw).
Since you'll be migrating a Java version, I'd suppose you'd better stick with the original regexps since they're untouched.

from libphonenumber-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.