Giter Site home page Giter Site logo

Comments (1)

mikecx avatar mikecx commented on September 22, 2024

Hey @iftheshoefritz, some good feedback there and something we hadn't hit yet due to our usage patterns. The return object already has response.success? so you should be good to go if you decide to go down that path.

Looking at our usage of it, we have it contained in a small wrapper class. In our wrapper we raise PandaDocError, response.as_json unless response.success? and then parse the error message out in the PandaDocError class using the type and detail fields. While it works, I can certainly agree with you that it doesn't feel super clean or DRY.

If you'd like to create that PR to add the bang methods, i'm all for it.

from pandadoc-api.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.