Comments (7)
The python binding installation is working like a charm!! I am planning to do the tests in python (in the future I can replicate them for the C++ version).
I managed to get nose
to work, but that required manual configurations. I found that nose
is no longer maintained. Its successor, nose2
, encourages migrating to pytest
(I have used this one in the past, so I am familiar with it).
I am going to rewrite previous tests, then implement new ones with the pytest
testing framework.
from brush.
Hello William,
I have some questions regarding coefficient optimization.
As far as I understood, if the node has is_weighted=true
, then the weights are applied to each of its children. A weighted sqrt
would be equivalent to sqrt(w*<child>)
.
I was trying to somehow add and adjust external weights as well. My question is: in order to have an external weight (such as w2*sqrt(w*<child>)
), then the parent of sqrt
should be a node with is_weighted
set to true as well? Or the weight could explicitly be created by multiplying a constant node with sqrt(...)
?
Also, do constant nodes have its values fixed, or they can be adjusted through optimization as well? I have tried to create constant nodes manually by using your json parser, but I didn't managed to get it working.
Regarding organization:
- Should I test every operator? (if so, is that ok to populate
/docs/examples/datasets/
with generated files, or it is better to have it hardcored in the tests?) - I'm thinking about separating the optimization tests into an individual file, is that ok?
from brush.
Hello William,
I have some questions regarding coefficient optimization.
As far as I understood, if the node has
is_weighted=true
, then the weights are applied to each of its children. A weightedsqrt
would be equivalent tosqrt(w*<child>)
.
Yes that's right! This is a design choice that we might want to revisit. I set it up this way to make backpropagation easier, but now that ceres is handling weight updates, we could put the weights anywhere.
I was trying to somehow add and adjust external weights as well. My question is: in order to have an external weight (such as
w2*sqrt(w*<child>)
), then the parent ofsqrt
should be a node withis_weighted
set to true as well? Or the weight could explicitly be created by multiplying a constant node withsqrt(...)
?
Yes, that's correct.
Also, do constant nodes have its values fixed, or they can be adjusted through optimization as well? I have tried to create constant nodes manually by using your json parser, but I didn't managed to get it working.
I have not spend enough time on the Constants, they need to be developed. Let me know what is happening. We should probably prioritize getting them working.
Regarding organization:
- Should I test every operator? (if so, is that ok to populate
/docs/examples/datasets/
with generated files, or it is better to have it hardcored in the tests?)- I'm thinking about separating the optimization tests into an individual file, is that ok?
Maybe it's better to hard code the tests rather than have a lot of data files.
Also, if it's easier you can now write the tests in Python using the pybind11 bindings:
brush/tests/python/test_program.py
Line 52 in 4b33242
from brush.
from brush.
hey @gAldeia , I made a change to reorder the constants so that they are applied to the outside of the operators. It's on this branch; https://github.com/cavalab/brush/tree/reorder_constants
I think we should go with that going forward. Could you incorporate this into the tests you've written?
from brush.
Hello @lacava! I think this modification is clear to me. Function nodes still have weights, but terminal nodes can have coefficients now. I will work on adjusting the tests!
from brush.
Hi @lacava! During our meeting, I mentioned that I wasn't able to build the docs.
I think this is a problem on my machine, since the GitHub job managed to successfully compile the docs and execute the tests.
from brush.
Related Issues (20)
- understand Ceres HOT 1
- design cost function for optimizing arbitrary function weights
- ability to optimize the weights of an arbirtrary function
- integrate ceres into Brush
- step through Operon's implementation of NNLS with Ceres HOT 1
- Brush is incompatible with MacOS HOT 3
- Warning doxygenclass: Cannot find class “Brush::Program” in doxygen xml output for project “brush” from directory: /path/to/brush/build/docs/doxygen/xml
- include pure python and cpp modules HOT 1
- add tqdm progress bar
- limits on max size / depth for crossover/mutation HOT 1
- Improved time series operators
- add random seed control
- Logger class HOT 1
- Program class
- Operators and Nodes
- Write Python bindings to program.cc HOT 1
- docs build commands HOT 2
- Compilation Error HOT 3
- specify dependencies HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brush.