Naming of NATSymmetricUDPFirewall

[ccding]

Naming of NATSymmetricUDPFirewall

[ccding]

@olifre Can you have a look at #34 ?

[xiang90]

@olifre

can you send a PR to fix this?

[olifre]

@xiang90 In principle yes, but there are two problems:

• I don't know if there should be an alias (for a while?) to not break API compatibilitiy with other users (e.g. syncthing) hard.
• I basically only know Go well enough to read it, so I would only be able to do a search / replace (but well, that's really sufficient here I think 😉 ).

[ccding]

closing this since no PR. The name indicates the meaning: https://github.com/ccding/go-stun/blob/master/stun/const.go#L62

[olifre]

@ccding I could of course do a PR on this, but I'd love feedback first if an alias should be kept and if there's general agreement on a new name.
The current name seems irritating even though the description is clear. Since the broken name NATSymmetricUDPFirewall has already lead to confusion in Syncthing (which did consider this a NAT, but it's completely unrelated), I don't think it's good to keep that.