Comments (10)
@simonschaufi Good tip. We'll look into this.
from unmark.
@simonschaufi I'm putting together release 1.5.6 and thought of including this. Would you like to take a swing at it and send a Pull Request?
from unmark.
@cdevroe i have an idea already but i need to have a deeper look into the code.
from unmark.
@simonschaufi If you don't get the chance, I'll tackle it after I button up #52.
from unmark.
@simonschaufi @kyleruane and I were talking a day or two ago about this issue. We wondered if we'd be good web citizens for removing this cruft? While the URL would look much nicer I'm unsure if we'd be unfair to the publisher. They are using this information to track referrals and while Unmark would be the referral in this instance... somehow you originally got the link from another source that included all of that information.
I wonder if we should leave this in but perhaps hide it from showing up in the app?
from unmark.
My opinion here is that i already visited this url with the special "campaign" parameters. When i save the bookmark in unmark, the link has no direct relation any more to the campaign. The referrer is still tracked but just the campaign info is gone but thats ok imho.
I'm more interested in the uniqueness of the link since when i save the link again without the parameters, i will have a duplicate in my db.
from unmark.
These are very good points. The way bookmarks are currently added (from the actual page), it makes sense to remove the utm_ string because, as @simonschaufi said, it has already served its purpose.
from unmark.
Google isn't the only game in town... are there any other services that adds cruft to a URL that we'd like to look for as well?
from unmark.
@simonschaufi If you want to pull this feature branch and give it a whirl. I did some local testing and it seems to work.
I had to add a helper. http_build_url is an extremely useful function that cuts down on a lot of code. But is only available via PECL. So I added a helper for those that do not have PECL.
Thanks for your feedback on this.
from unmark.
This is now available for testing in the Milestone 1.6 branch.
from unmark.
Related Issues (20)
- Importing HTML / Unmark export redirects to a white page HOT 5
- Page not displayed correctly HOT 3
- Search Archive when on Archive
- $config['unmark_version'] update in config.php? HOT 4
- How to use PHP for simple scaffolding?
- Wrong release uploaded HOT 1
- The exported file contains deleted marks HOT 6
- Loading more marks does not work properly HOT 2
- Support importing marks with tags HOT 1
- Offical backup and restore script HOT 3
- Make Unmark available on Docker Hub HOT 2
- setup ? HOT 7
- A Database Error Occurred Error Number: 1146
- Default branch link
- openssl error when adding url
- Project status HOT 4
- Update CI to 3.1.13
- How can I delete my unmark.it account? I couldn't reach support
- XSS vulnerability
- When adding a mark through the bookmarklet, a question mark in the title or the url throws the pop-up off
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unmark.