Comments (5)
Thanks! That was the problem :)
In the code I added:
app.use(express.json());
app.use(express.text());
from express-openapi-validator.
Note: In the example above there is also an enum on the string value, but it can be removed for this sample. The issue is with the string type - not the enum.
from express-openapi-validator.
@gonenduk Can you ensure you are able to parse body text
For example, ensure you're express app is set up to to parse both text and json bodies. For example, you might use the bodyParser
middleware:
e.g.
app.use(bodyParser.text());
app.use(bodyParser.json());
i have a hunch that perhaps everything is forced to json and thus the validator is getting req.body
with a value of empty JSON object e.g. {}
, rather than the expected string value e.g. whatever string the caller PUT
assuming this is the case, the validator should, at least, throw some kind of validation error stating that it received JSON not {}
text instead of a string value (and if it can distinguish, perhaps a note about the body parser to help dev's sort the issue or even)
also, assuming this is the case, i wonder if the validator should optionally install relevant body parsers. something like this may overstep the scope of the validator. users should have choice. food for thought. if you have opinions, please share
from express-openapi-validator.
Fantastic! I added some notes to the README. Do you feel the validator should do more here, that is beyond some notes in the README it.
from express-openapi-validator.
Not sure there is anything you can do in the validator in this case.
Maybe extend the error message after saying it should be a string, add the type you got - in my case i believe it was undefined (it was not a json and there was no parser for text so req.body left undefined)
maybe adding the typeof req.body to the error message info will help. But I'm not so sure about this.
from express-openapi-validator.
Related Issues (20)
- Security handlers cannot access request params
- The validation doesn't work at all HOT 2
- Question: should serdes.serialize be called when validateResponse=false
- Serdes Does Not Work for Items in Request Parameters in Array HOT 1
- HTTP HEAD not implemented for HTTP GET similar to ExpressJS v4.
- Multer worked on 5.0.1 throws internal server error in 5.1.0 HOT 5
- Introduction of multiple swagger docs with new endpoint now versioned returns 404 HOT 2
- the same oneOf schema can pass request validation. But cannot pass response validation
- version 5.1.1, apiKey cookie authentication results in error HOT 1
- Email format validation does not accept non-ascii characters
- Multiple spec support breaks if validateResponses: true HOT 2
- readonly is ignored when properties are inherited through allOf
- Type coercion stops working if request validation is turned off HOT 1
- Support for the HyperExpress web framework HOT 1
- Multiple path params break support for URI path param HOT 1
- Upgrade or replace lodash
- Server variables without enum don't get validated
- Multiple specs are not supported HOT 1
- Found CVE-2021-23337 in latest version of express-openapi-validator HOT 1
- Request body is marked as invalid, using `oneOf` inside `allOf`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from express-openapi-validator.