Too small height for Korean in non-expanded interface.

[cdrummond]

Too small height for Korean in non-expanded interface.

[GoogleCodeExporter]

I dont have any non-english titled tracks. Could you provide a screenshot of 1 
the above tracks when the interface is expanded? How many pixels do you /think/ 
are missing?

The current font-metrics are taken into account when determining the collapsed 
size.

Could you try editing gui/mainwindow.cpp and change line 2440 from:

----------------------8<------------------------
        compactHeight=qMax(qMax(playPauseTrackButton->height(), trackLabel->height()+artistLabel->height())+
----------------------8<------------------------

to 

----------------------8<------------------------
        compactHeight=qMax(qMax(playPauseTrackButton->height(), trackLabel->height()+artistLabel->height()+spacing)+
----------------------8<------------------------

Does this help at all???

Original comment by [email protected] on 14 Jun 2012 at 7:38

• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Expanded interface is fine as below.
Adding '+spacing' to gui/maiwindow.cpp doesn't fix the problem!

Original comment by [email protected] on 14 Jun 2012 at 7:52

Attachments:

• [Screenshot from 2012-06-13 11:41:54.png](https://storage.googleapis.com/google-code-attachments/cantata/issue-35/comment-2/Screenshot from 2012-06-13 11:41:54.png)

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

This is, again, a style issue. For some reason the Gtk+ Qt style is giving a 
spacing value of -1 when queried.

Try editing gui/mainwindow.cpp and changing from (line 2438):

----------------------8<------------------------
        int spacing=style()->layoutSpacing(QSizePolicy::DefaultType, QSizePolicy::DefaultType, Qt::Vertical);
        // For some reason height is always larger than it needs to be - so fix this to cover height +4
        compactHeight=qMax(qMax(playPauseTrackButton->height(), trackLabel->height()+artistLabel->height())+
                           songTimeElapsedLabel->height()+positionSlider->height()+(spacing*3),
                           coverWidget->height()+spacing);
----------------------8<------------------------

to:

----------------------8<------------------------
        int spacing=style()->layoutSpacing(QSizePolicy::DefaultType, QSizePolicy::DefaultType, Qt::Vertical);
        if (spacing<0) {
            spacing=4;
        }
        // For some reason height is always larger than it needs to be - so fix this to cover height +4
        compactHeight=qMax(qMax(playPauseTrackButton->height(), trackLabel->height()+artistLabel->height()+spacing)+
                           songTimeElapsedLabel->height()+positionSlider->height()+(spacing*2),
                           coverWidget->height()+spacing);
----------------------8<------------------------

This seems to resolve the issue for me

Original comment by [email protected] on 14 Jun 2012 at 8:08

[GoogleCodeExporter]

Yes, now it works fine for Korean, Japanese and probably Chinese!

Thanks as always.

Original comment by [email protected] on 14 Jun 2012 at 8:22

[GoogleCodeExporter]

Fixed in r1238

Original comment by [email protected] on 14 Jun 2012 at 7:09

• Changed state: Fixed