Giter Site home page Giter Site logo

Comments (4)

cduck avatar cduck commented on August 27, 2024

Thanks for opening the feature request. Here is a list of new methods that we need to write for this feature:

  • New method segmentIntersectionsWithHcycle(self, hcycle2) on Hypercycle. This method will first call intersectionsWithHcycle and only return the points that are true for self.isPointOnSegment(x, y) and hcycle2.isPointOnSegment(x, y). This methods does what you want by only returning the intersections that are contained within both segments and returning nothing otherwise.

Helper methods:

  • New method isPointOnSegment(self, x, y) on Hypercycle. Check if the point is between or outside the endpoints by asking its underlying euclidean shape: return self.projShape.isPointOnSegment(x, y) (see below)

  • New method isPointOnSegment(self, x, y) on euclid.Line. This method will check if the point is between or outside the endpoints.

  • New method isPointOnSegment(self, x, y) on euclid.Circle. Always returns true because a circle doesn't have endpoints.

  • New method isPointOnSegment(self, x, y) on euclid.Arc. Checks if the point's radial angle is between startDeg and endDeg.

Let me know if you need more detail or have any questions.

from hyperbolic.

mckvv avatar mckvv commented on August 27, 2024

This looks gret! Thank you for now.
I understand better what we need to do. But I am afraid, that with my experience I'm not able to implement these features by myself. Could you help me with that? I think similar features would be useful for other users.

from hyperbolic.

smh0109 avatar smh0109 commented on August 27, 2024

Apparently I was working on a very similar feature rigth now, I could probably create a branch to impelment this...

from hyperbolic.

cduck avatar cduck commented on August 27, 2024

That would be great @smh0109. Post here or open a pull request if you want any feedback.

from hyperbolic.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.