Comments (4)
Thanks for opening the feature request. Here is a list of new methods that we need to write for this feature:
- New method
segmentIntersectionsWithHcycle(self, hcycle2)
onHypercycle
. This method will first callintersectionsWithHcycle
and only return the points that are true forself.isPointOnSegment(x, y)
andhcycle2.isPointOnSegment(x, y)
. This methods does what you want by only returning the intersections that are contained within both segments and returning nothing otherwise.
Helper methods:
-
New method
isPointOnSegment(self, x, y)
onHypercycle
. Check if the point is between or outside the endpoints by asking its underlying euclidean shape:return self.projShape.isPointOnSegment(x, y)
(see below) -
New method
isPointOnSegment(self, x, y)
oneuclid.Line
. This method will check if the point is between or outside the endpoints. -
New method
isPointOnSegment(self, x, y)
oneuclid.Circle
. Always returns true because a circle doesn't have endpoints. -
New method
isPointOnSegment(self, x, y)
oneuclid.Arc
. Checks if the point's radial angle is between startDeg and endDeg.
Let me know if you need more detail or have any questions.
from hyperbolic.
This looks gret! Thank you for now.
I understand better what we need to do. But I am afraid, that with my experience I'm not able to implement these features by myself. Could you help me with that? I think similar features would be useful for other users.
from hyperbolic.
Apparently I was working on a very similar feature rigth now, I could probably create a branch to impelment this...
from hyperbolic.
That would be great @smh0109. Post here or open a pull request if you want any feedback.
from hyperbolic.
Related Issues (14)
- Code for the example image && add upper half plane model HOT 6
- Tiling with lines of constant thickness
- Polygon.fromVertices chooses wrong orientation for ideal edges HOT 2
- 'Transform' has no attribute 'diskToHalf'; Acknowledgement in Publications HOT 3
- Transform.merge produces incorrect output for non-orientation-preserving transformations HOT 2
- Transforms have determinant 1? HOT 1
- Isn't the point in Poincare model in visualisation inverted? HOT 2
- Still maintained? HOT 5
- Add arrow example HOT 2
- Add documentation for the weave pattern example HOT 4
- Help creating Farey diagram HOT 2
- tilling isosceles triangles HOT 2
- counting ideal points of a hyperbolic line
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyperbolic.