Giter Site home page Giter Site logo

Comments (7)

bradyvercher avatar bradyvercher commented on June 11, 2024

I really like this idea! This should just be a matter of including the WP i18n tools into the lib directory and changing the default path. The config options are still nice in case the version gets outdated or someone wants to use a customized version.

from grunt-wp-i18n.

tollmanz avatar tollmanz commented on June 11, 2024

I'm 100% behind that. If you want/need to have the absolutely latest version, you can maintain that on your own and point to it.

from grunt-wp-i18n.

bradyvercher avatar bradyvercher commented on June 11, 2024

Actually, it looks like the tools would need to be forked with some minor updates. I'm assuming the new develop structure moved some dependencies into core in preparation for languages packs: https://core.trac.wordpress.org/browser/trunk/tools/i18n/extract.php#L2

And an amusing commit that ran into the same issue: johnpbloch/packages@93ff2b9

from grunt-wp-i18n.

tollmanz avatar tollmanz commented on June 11, 2024

Ah...I see. I think it still makes sense to include it. Dependency reduction is a major win.

from grunt-wp-i18n.

bradyvercher avatar bradyvercher commented on June 11, 2024

Totally agree. I tried to make all config optional with sensible defaults, so this will just make it that much easier.

from grunt-wp-i18n.

bradyvercher avatar bradyvercher commented on June 11, 2024

I forked the i18n tools, bundled them and updated the include paths so that's one less dependency.

from grunt-wp-i18n.

tollmanz avatar tollmanz commented on June 11, 2024

Woot! This is huge. Awesome work!

from grunt-wp-i18n.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.