`addtextdomain --dry-run` is not working

[cedaro]

`addtextdomain --dry-run` is not working

[bradyvercher]

Thanks for the report @tamarazuk! At some point, I think this prevented the argument from being passed to the PHP script. I'm not sure if something changed or if it really just never worked.

I imagine getting rid of that argument shifting hocus pocus in grunt-add-textdomain.php should fix this up, though.

[tamarazuk]

@bradyvercher Thanks for the quick reply 🍻

The task is always passing the second argument (but it's an empty string when we're doing a dry run) whereas the grunt-add-textdomain.php assumes the command was run in the shell so the argument might not exist. So I agree, removing the shifting hocus pocus and adjusting the indexes should fix it. Alternatively, moving the array_shift() here outside of the if can work too.

[bradyvercher]

Hey @tamarazuk, if you can let me know if that commit fixes your issue, I'll go ahead and push out a new release.

[tamarazuk]

@bradyvercher looks like that fixed it 😸 Thanks!

[bradyvercher]

Just pushed this out in v0.5.3. Thanks again! 🍻