Comments (5)
From discussions with the VecGeom team it sounds like we might be able to reduce the displaced solids to regular solids by propagating the displacement into the "placement" of the physical volumes.
Yes, that's a good idea. In Geant4 a boolean has 2 logical volumes as members whereas in VecGeom there are 2 placed volumes. A logical displaced volume should be straightforwardly convertible.
from celeritas.
Since you have the code already I would say just go ahead -:)
I believe the assumption might be based on some documentation but potentially the gdml converter or some other unit does not seem to respect it.
from celeritas.
I made a PR with the replica treatment. Feel free to use it or take it as inspiration. I am now locally able to convert my test geometry.
from celeritas.
@sethrj : After inspection of the conversion code, I believe you should already be doing the right thing. But there might be a wrong assumption that only the second volume could be a displaced volume. In fact, after switching on assertations, I see:
.../app/celer-g4/celer-g4.cc:297: critical: While running input_gun.json: celeritas/ext/g4vg/SolidConverter.cc:696:
celeritas: Geant4 error: celer0001 failed:
precondition failed: !dynamic_cast<G4DisplacedSolid const*>(solids[0])
So simply extending the treatment to the first volume might be enough. Shall I provide a PR?
from celeritas.
@sawenzel Yes that was an assumption inherited from an earlier version of the vecgeom->Geant4 converter. I actually just found the same thing and am about to submit the PR! Thanks though. If you'd like to add the PV expansion we'd love to include your contribution 😄
from celeritas.
Related Issues (20)
- Implement short-circuit volume evaluation using infix notation HOT 1
- Improve physics memory utilization and performance
- Replace StreamStore and helpers with reduction function
- Construct optical photon physics cross section tables HOT 2
- `G4VDecayChannel`: `G4MuonDecayChannel` HOT 1
- Optimize track vector data layout for particle types
- Debug parallel crashes running with multiple streams on Frontier HOT 1
- Fix performance regression in ORANGE testem3 HOT 6
- Add 3D raytrace visualizer
- DUNE integration
- LZ integration
- ePIC integration HOT 5
- LEGEND integration HOT 1
- ALICE integration
- Support optical surface interfaces HOT 2
- Define "volume instance" IDs and expose physical volumes for Geant4/VecGeom
- Refactor and optimize field propagation
- Move RNGs down to corecel
- Optical photon stepping loop
- Basic muon decay physics
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from celeritas.